Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case insensitive query on wildcard field #15882

Conversation

HUSTERGS
Copy link
Contributor

Description

fix case insensitive query on wildcard field

Related Issues

Resolves #15855

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for c373ab2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for cf04117: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@HUSTERGS HUSTERGS requested a review from msfroh September 11, 2024 05:12
@HUSTERGS
Copy link
Contributor Author

I rebased on the main branch for merge conflict, thus need another approval :D, thanks @msfroh

@dblock dblock added the backport 2.x Backport to 2.x branch label Sep 11, 2024
@dblock
Copy link
Member

dblock commented Sep 11, 2024

@HUSTERGS update CHANGELOG please?

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
@HUSTERGS
Copy link
Contributor Author

CHANGELOG added, sorry forgot again :( need another approval, thanks @dblock

Copy link
Contributor

❌ Gradle check result for 94f528b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 94f528b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 94f528b: SUCCESS

@jainankitk jainankitk merged commit aaa92ae into opensearch-project:main Sep 13, 2024
35 of 36 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 13, 2024
* fix case insensitive query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix YAML test

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
(cherry picked from commit aaa92ae)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sachinpkale pushed a commit to sachinpkale/OpenSearch that referenced this pull request Sep 19, 2024
* fix case insensitive query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix YAML test

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
msfroh pushed a commit that referenced this pull request Oct 2, 2024
* fix case insensitive query on wildcard field
* fix YAML test
* add change log

---------

(cherry picked from commit aaa92ae)

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: gaobinlong <gbinlong@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gaobinlong <gbinlong@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
* fix case insensitive query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix YAML test

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
* fix case insensitive query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix YAML test

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
* fix case insensitive query on wildcard field

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* fix YAML test

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

* add change log

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>

---------

Signed-off-by: gesong.samuel <gesong.samuel@bytedance.com>
Co-authored-by: gesong.samuel <gesong.samuel@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Search Search query, autocomplete ...etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] case_insensitive wildcard query didn't return expected result
4 participants