Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for Workload Management CRUD APIs #15955

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

ruai0511
Copy link
Contributor

@ruai0511 ruai0511 commented Sep 16, 2024

Add Integration Tests for workload management CRUD APIs in plugin
For more information regarding workload management, refer to this RFC: #12342.

This IT can be run using

./gradlew ':plugins:workload-management:javaRestTest' \
  --tests "org.opensearch.rest.WorkloadManagementRestIT"

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruai0511 ruai0511 added the backport 2.x Backport to 2.x branch label Sep 16, 2024
@ruai0511 ruai0511 changed the title Add Integration Tests for workload management CRUD APIs Add Integration Tests for Workload Management CRUD APIs Sep 16, 2024
Copy link
Contributor

❌ Gradle check result for 4b0f7a0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 870aff0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 7f88472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can refactor some request bodies with json utilities to make these tests more readable:

 public static String getCreateJson(String name, String resiliencyMode, double cpu, double memory) {
        return "{\n" +
            "    \"name\": \"" + name + "\",\n" +
            "    \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
            "    \"resource_limits\": {\n" +
            "        \"cpu\" : " + cpu + ",\n" +
            "        \"memory\" : " + memory + "\n" +
            "    }\n" +
            "}";
    }

    public static String getUpdateJson(String resiliencyMode, double cpu, double memory) {
        return "{\n" +
            "    \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
            "    \"resource_limits\": {\n" +
            "        \"cpu\" : " + cpu + ",\n" +
            "        \"memory\" : " + memory + "\n" +
            "    }\n" +
            "}";
    }

Copy link
Contributor

❕ Gradle check result for f81637f: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 3ab8324: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 3ab8324: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 3ab8324: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 3ab8324: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

@ruai0511 - you need to merge from main:

org.opensearch.qa.verify_version_constants.VerifyVersionConstantsIT.testLuceneVersionConstant
Failing for the past 1 build (Since
[#49165](https://build.ci.opensearch.org/job/gradle-check/49165/) )
[Took 0.53 sec.](https://build.ci.opensearch.org/job/gradle-check/49165/testReport/junit/org.opensearch.qa.verify_version_constants/VerifyVersionConstantsIT/testLuceneVersionConstant/history)
Error Message

java.lang.AssertionError: 
Expected: <9.12.0>
     but: was <9.11.1>

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 4fb7e69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 4fb7e69: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 4fb7e69:

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 4fb7e69: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationAllocationIT.testSingleIndexShardAllocation

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@jainankitk jainankitk merged commit b3b8c9b into opensearch-project:main Oct 10, 2024
33 of 34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15955-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b3b8c9b61e90c62c63eca14af0969e2071e79b14
# Push it to GitHub
git push --set-upstream origin backport/backport-15955-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15955-to-2.x.

ruai0511 added a commit to ruai0511/OpenSearch that referenced this pull request Oct 10, 2024
…roject#15955)

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit b3b8c9b)
ruai0511 added a commit to ruai0511/OpenSearch that referenced this pull request Oct 10, 2024
…roject#15955)

Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit b3b8c9b)
jainankitk pushed a commit that referenced this pull request Oct 10, 2024
…#15955) (#16275)

* Add Integration Tests for Workload Management CRUD APIs (#15955)
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit b3b8c9b)

* Add Integration Tests for Workload Management CRUD APIs (#15955)
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
(cherry picked from commit b3b8c9b)
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…roject#15955)

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…roject#15955)

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…roject#15955)

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* modify based on comments
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>

* add IT for workload management  CRUD APIs
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants