-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Integration Tests for Workload Management CRUD APIs #15955
Conversation
❌ Gradle check result for 4b0f7a0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 870aff0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 7f88472: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refactor some request bodies with json utilities to make these tests more readable:
public static String getCreateJson(String name, String resiliencyMode, double cpu, double memory) {
return "{\n" +
" \"name\": \"" + name + "\",\n" +
" \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
" \"resource_limits\": {\n" +
" \"cpu\" : " + cpu + ",\n" +
" \"memory\" : " + memory + "\n" +
" }\n" +
"}";
}
public static String getUpdateJson(String resiliencyMode, double cpu, double memory) {
return "{\n" +
" \"resiliency_mode\": \"" + resiliencyMode + "\",\n" +
" \"resource_limits\": {\n" +
" \"cpu\" : " + cpu + ",\n" +
" \"memory\" : " + memory + "\n" +
" }\n" +
"}";
}
❕ Gradle check result for f81637f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❌ Gradle check result for 3ab8324: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3ab8324: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3ab8324: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 3ab8324: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@ruai0511 - you need to merge from
|
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
❌ Gradle check result for 4fb7e69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4fb7e69: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 4fb7e69: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 4fb7e69: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15955-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b3b8c9b61e90c62c63eca14af0969e2071e79b14
# Push it to GitHub
git push --set-upstream origin backport/backport-15955-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…roject#15955) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit b3b8c9b)
…roject#15955) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit b3b8c9b)
…#15955) (#16275) * Add Integration Tests for Workload Management CRUD APIs (#15955) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit b3b8c9b) * Add Integration Tests for Workload Management CRUD APIs (#15955) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> (cherry picked from commit b3b8c9b)
…roject#15955) * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
…roject#15955) * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
…roject#15955) * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * modify based on comments Signed-off-by: Ruirui Zhang <mariazrr@amazon.com> * add IT for workload management CRUD APIs Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Add Integration Tests for workload management CRUD APIs in plugin
For more information regarding workload management, refer to this RFC: #12342.
This IT can be run using
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.