[Star tree] Refactoring builder tests #16036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16036 +/- ##
============================================
- Coverage 71.94% 71.88% -0.07%
- Complexity 64612 64681 +69
============================================
Files 5298 5303 +5
Lines 301952 302476 +524
Branches 43627 43699 +72
============================================
+ Hits 217247 217430 +183
- Misses 66884 67185 +301
- Partials 17821 17861 +40 ☔ View full report in Codecov by Sentry. |
bharath-techie
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
sarthakaggarwal97
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Thanks @bharath-techie for taking this refactor. Definitely helps with segregation of tests.
Could not verify all the tests, spot checked few. Approving since we have not changed any internal workings of all the tests.
bharath-techie
force-pushed
the
startestrefactor
branch
from
77112f4 to
7c001ee
Compare
|
❌ Gradle check result for 7c001ee: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
bharath-techie
force-pushed
the
startestrefactor
branch
from
7c001ee to
11c3838
Compare
|
❌ Gradle check result for 11c3838: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Oct 7, 2024
Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
sachinpkale
approved these changes
Oct 8, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Refactoring builder tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * adding date tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com> (cherry picked from commit 3696c29) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Oct 16, 2024
(cherry picked from commit 3696c29) Signed-off-by: Bharathwaj G <bharath78910@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 16, 2024
* Refactoring builder tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * adding date tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 17, 2024
* Refactoring builder tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * adding date tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
dk2k
pushed a commit
to dk2k/OpenSearch
that referenced
this pull request
Oct 21, 2024
* Refactoring builder tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> * adding date tests Signed-off-by: Bharathwaj G <bharath78910@gmail.com> --------- Signed-off-by: Bharathwaj G <bharath78910@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The AbstractBuilderTests has grown to be around 4500 lines long, and its very difficult to write new tests for future builder changes in the same file. So this PR just splits the tests into different categories such as flush, merge , sort and aggregate tests and so on.
Ideally, we also need to remove the hardcoded configurations in StarTreeBuilderTestCase. Will further check how to optimize that.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.