-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for docker compose v2 in TestFixturesPlugin #16049
Add support for docker compose v2 in TestFixturesPlugin #16049
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
fd11a18
to
4b6ecf8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16049 +/- ##
============================================
- Coverage 71.99% 71.89% -0.11%
+ Complexity 64408 64362 -46
============================================
Files 5281 5281
Lines 301003 301010 +7
Branches 43483 43486 +3
============================================
- Hits 216721 216413 -308
- Misses 66522 66798 +276
- Partials 17760 17799 +39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but ideally it should be figuring out which version of compose is available then using a map to run a different commend, avoids if's
;)
* Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <cwperx@amazon.com> * Support both Signed-off-by: Craig Perkins <cwperx@amazon.com> * Check if V2 is available Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG text Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 6a29119) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
) * Update references for docker-compose to docker compose * Support both * Check if V2 is available * Add to CHANGELOG * Update CHANGELOG text --------- (cherry picked from commit 6a29119) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…roject#16049) * Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <cwperx@amazon.com> * Support both Signed-off-by: Craig Perkins <cwperx@amazon.com> * Check if V2 is available Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG text Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…roject#16049) * Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <cwperx@amazon.com> * Support both Signed-off-by: Craig Perkins <cwperx@amazon.com> * Check if V2 is available Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG text Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…roject#16049) * Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <cwperx@amazon.com> * Support both Signed-off-by: Craig Perkins <cwperx@amazon.com> * Check if V2 is available Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG text Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…roject#16049) * Update references for docker-compose to docker compose Signed-off-by: Craig Perkins <cwperx@amazon.com> * Support both Signed-off-by: Craig Perkins <cwperx@amazon.com> * Check if V2 is available Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG text Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
While looking into upgrading google dependencies to v2, I ran into an issue where docker compose related gradle tasks were being skipped on my Mac due to
docker-compose
not being present. This PR adds support for Docker Compose V2 (docker compose
- without the hyphen)Related Issues
Resolves: #16050
Dependabot updates have been failing for google related dependencies due to major version upgrade. Example: #16043
opensearch-api-specification repo did a similar update: opensearch-project/opensearch-api-specification#457
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.