Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flaky Test RecoveryFromGatewayIT.testShardStoreFetchMultiNodeMultiIndexesUsingBatchAction #16093

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

kkewwei
Copy link
Contributor

@kkewwei kkewwei commented Sep 26, 2024

Description

In RecoveryFromGatewayIT test, the created indices may be not started yet, but is used immediately, which will cause unexpected exception. when it throws the exception, the scene is as follows:
img_v3_02f3_5a00dfcc-7a54-4a19-a23d-eb24554f53cg

Related Issues

Resolves #14304

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for c29a7c1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 250a33b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 99a1b04: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kkewwei kkewwei force-pushed the fix_14304 branch 2 times, most recently from ba7d90c to c6058a6 Compare September 27, 2024 11:58
Copy link
Contributor

❌ Gradle check result for c6058a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 7, 2024

❌ Gradle check result for c6058a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for cee67fe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for cee67fe: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…StoreFetchMultiNodeMultiIndexesUsingBatchAction

Signed-off-by: kkewwei <kkewwei@163.com>
Copy link
Contributor

✅ Gradle check result for 9e3e924: SUCCESS

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.90%. Comparing base (e7757e7) to head (9e3e924).
Report is 5 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16093      +/-   ##
============================================
- Coverage     71.97%   71.90%   -0.08%     
+ Complexity    64771    64707      -64     
============================================
  Files          5302     5302              
  Lines        302473   302473              
  Branches      43699    43699              
============================================
- Hits         217715   217498     -217     
- Misses        66950    67150     +200     
- Partials      17808    17825      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkewwei
Copy link
Contributor Author

kkewwei commented Oct 10, 2024

@gaobinlong it's ok now, please have a look.

@gaobinlong gaobinlong merged commit 9e53d9b into opensearch-project:main Oct 10, 2024
34 checks passed
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 16, 2024
…StoreFetchMultiNodeMultiIndexesUsingBatchAction (opensearch-project#16093)

Signed-off-by: kkewwei <kkewwei@163.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 17, 2024
…StoreFetchMultiNodeMultiIndexesUsingBatchAction (opensearch-project#16093)

Signed-off-by: kkewwei <kkewwei@163.com>
dk2k pushed a commit to dk2k/OpenSearch that referenced this pull request Oct 21, 2024
…StoreFetchMultiNodeMultiIndexesUsingBatchAction (opensearch-project#16093)

Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Cluster Manager flaky-test Random test failure that succeeds on second run >test-failure Test failure from CI, local build, etc.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Gradle Check Flaky Test Report for RecoveryFromGatewayIT
3 participants