Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix for race condition in node-join/node-left loop #16118

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1563e1a from #15521.

* Add custom connect to node for handleJoinRequest

Signed-off-by: Rahul Karajgikar <karajgik@amazon.com>
(cherry picked from commit 1563e1a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for 83ea071: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 83ea071: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.77%. Comparing base (b180569) to head (83ea071).
Report is 7 commits behind head on 2.x.

Files with missing lines Patch % Lines
.../opensearch/transport/RemoteConnectionManager.java 0.00% 4 Missing ⚠️
...g/opensearch/cluster/coordination/Coordinator.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #16118      +/-   ##
============================================
- Coverage     71.79%   71.77%   -0.02%     
- Complexity    64798    64813      +15     
============================================
  Files          5278     5278              
  Lines        302676   302713      +37     
  Branches      44037    44038       +1     
============================================
- Hits         217303   217277      -26     
- Misses        67226    67312      +86     
+ Partials      18147    18124      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shwetathareja shwetathareja merged commit 8f585d0 into 2.x Sep 30, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant