-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing opensearch-x-content lib as dependency to other libs #16142
base: main
Are you sure you want to change the base?
Conversation
❕ Gradle check result for 2aa2174: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16142 +/- ##
============================================
+ Coverage 71.86% 71.97% +0.11%
- Complexity 64447 64521 +74
============================================
Files 5288 5288
Lines 301438 301438
Branches 43552 43552
============================================
+ Hits 216628 216970 +342
+ Misses 67034 66676 -358
- Partials 17776 17792 +16 ☔ View full report in Codecov by Sentry. |
@Aayush8394 what is the use case for it? which library (or libraries) you are referring to that need(s) |
@Aayush8394 Can you fix the spotless and DCO checks? To automatically apply spotless rules use |
This PR is stalled because it has been open for 30 days with no activity. |
This PR is stalled because it has been open for 30 days with no activity. |
Description
Currently, only
opensearch-core
andopensearch-common
libs are allowed as dependency to other libs. Allowingopensearch-x-content
lib to be used as a dependency in other libs as this lib has different types of XContent parsers. FOr ex: JsonXContentParser would be commonly needed to parse Json content. Otherwise each lib will have to write a duplicate implementation of AbstractXContentParser or introduce external library dependencies.opensearch-x-content
doesn't has a dependency on other libs and only depends on some Jackson library hence it won't create cyclic dependencies or bring in unnecessary dependencies.Related Issues
Resolves: None
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.