Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing opensearch-x-content lib as dependency to other libs #16142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aayush8394
Copy link

Description

Currently, only opensearch-core and opensearch-common libs are allowed as dependency to other libs. Allowing opensearch-x-content lib to be used as a dependency in other libs as this lib has different types of XContent parsers. FOr ex: JsonXContentParser would be commonly needed to parse Json content. Otherwise each lib will have to write a duplicate implementation of AbstractXContentParser or introduce external library dependencies. opensearch-x-content doesn't has a dependency on other libs and only depends on some Jackson library hence it won't create cyclic dependencies or bring in unnecessary dependencies.

Related Issues

Resolves: None

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❕ Gradle check result for 2aa2174: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.97%. Comparing base (8ddb3ee) to head (2aa2174).
Report is 198 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16142      +/-   ##
============================================
+ Coverage     71.86%   71.97%   +0.11%     
- Complexity    64447    64521      +74     
============================================
  Files          5288     5288              
  Lines        301438   301438              
  Branches      43552    43552              
============================================
+ Hits         216628   216970     +342     
+ Misses        67034    66676     -358     
- Partials      17776    17792      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta
Copy link
Collaborator

reta commented Oct 1, 2024

@Aayush8394 what is the use case for it? which library (or libraries) you are referring to that need(s) opensearch-x-content ?

@cwperks
Copy link
Member

cwperks commented Oct 4, 2024

@Aayush8394 Can you fix the spotless and DCO checks?

To automatically apply spotless rules use ./gradlew spotlessApply. When creating a commit, make sure to signoff the commits using --signoff. fe git commit -m "Message here" --signoff.

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Nov 5, 2024
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Nov 6, 2024
@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants