-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properties #16237
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
❌ Gradle check result for 655f784: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❕ Gradle check result for 655f784: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16237 +/- ##
============================================
+ Coverage 71.94% 72.05% +0.10%
- Complexity 64612 64802 +190
============================================
Files 5298 5303 +5
Lines 301952 302479 +527
Branches 43627 43699 +72
============================================
+ Hits 217247 217937 +690
+ Misses 66884 66649 -235
- Partials 17821 17893 +72 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no any reason to downgrade the TLS client protocols below TLSv1.2, we should add TLSv1.3 instead:
systemProp.jdk.tls.client.protocols=TLSv1.2,TLSv1.3
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Added TLSv1.3 in. |
Thanks @cwperks ! |
…es (#16237) * Remove force to TLSv1.2 in gradle.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add TLSv1.3 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit febbc00) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…es (#16237) (#16239) * Remove force to TLSv1.2 in gradle.properties * Add TLSv1.3 --------- (cherry picked from commit febbc00) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…es (opensearch-project#16237) * Remove force to TLSv1.2 in gradle.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add TLSv1.3 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…es (opensearch-project#16237) * Remove force to TLSv1.2 in gradle.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add TLSv1.3 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
…es (opensearch-project#16237) * Remove force to TLSv1.2 in gradle.properties Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add TLSv1.3 Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
This system property was introduced in 34ccd3f to resolve an issue connecting to services at build time that did not support TLSv1.3.
I'm opening this PR to add TLSv1.3 to this systemProp.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.