[Backport 2.x] Ensure index templates are not applied to system indices #16518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* fix: ensure system indices are processed without templates Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: overloaded method for creating without templates Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * test: adding test to check call for notemplates on system index Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: cchange modifier to package private and add entry in changelog Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * test: adding IT test Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: remove UT and add private modifiers Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> * refactor: spotless changes Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> --------- Signed-off-by: Pavan Yekbote <mail2pavanyekbote@gmail.com> (cherry picked from commit 1e7c122) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
reta
approved these changes
Oct 29, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #16518 +/- ##
============================================
+ Coverage 71.83% 71.85% +0.02%
- Complexity 65318 65379 +61
============================================
Files 5312 5312
Lines 304985 304994 +9
Branches 44436 44437 +1
============================================
+ Hits 219079 219161 +82
+ Misses 67609 67544 -65
+ Partials 18297 18289 -8 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1e7c122 from #16418.