-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump google-auth-library-oauth2-http from 1.7.0 to 1.29.0 in /plugins/repository-gcs #16520
Conversation
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for baef6b5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: gaobinlong <gbinlong@amazon.com>
❌ Gradle check result for 472d53d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 472d53d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 00c7cf9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Yes and no :) It seems like we are dealing with the same dependencies but plugins are different and versions are a bit messy, if you could help unify those, would be great (if it makes sense for sure). Thanks a lot! |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for b773a8b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b773a8b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b773a8b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for 0195c1d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
❌ Gradle check result for 216eebe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/repository-gcs/src/main/plugin-metadata/plugin-security.policy
Outdated
Show resolved
Hide resolved
❌ Gradle check result for 216eebe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 216eebe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16520 +/- ##
============================================
+ Coverage 72.00% 72.05% +0.04%
- Complexity 65038 65062 +24
============================================
Files 5313 5313
Lines 303454 303454
Branches 43910 43910
============================================
+ Hits 218510 218648 +138
+ Misses 67040 66901 -139
- Partials 17904 17905 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16520-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3f18562974612ceb36b66c773b6b8eb6d4dfc0b0
# Push it to GitHub
git push --set-upstream origin backport/backport-16520-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…/repository-gcs (opensearch-project#16520) * Bump from 1.7.0 to 1.29.0 in /plugins/repository-gcs Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * move version to top-level file Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix build failure Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Revert some change Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com>
…/repository-gcs (opensearch-project#16520) * Bump from 1.7.0 to 1.29.0 in /plugins/repository-gcs Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Add change log Signed-off-by: Gao Binlong <gbinlong@amazon.com> * move version to top-level file Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix build failure Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Fix test failure Signed-off-by: Gao Binlong <gbinlong@amazon.com> * Revert some change Signed-off-by: Gao Binlong <gbinlong@amazon.com> --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com>
…/repository-gcs (#16520) (#16638) * Bump from 1.7.0 to 1.29.0 in /plugins/repository-gcs * Add change log * move version to top-level file * Fix build failure * Fix test failure * Revert some change --------- Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com>
Description
google-auth-library-oauth2-http
needs to be upgraded to 1.29.0 because the new version ofcom.google.cloud:google-cloud-core-http
has a test dependency on it.Related Issues
No issue.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.