Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retrieving doc values of unsigned long field #16543

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

bugmakerrrrrr
Copy link
Contributor

Description

Implement the LeafFieldData#getLeafValueFetcher method for unsigned long field to support retrieving doc values. Previously, attempting to use the docvalue_fields parameter to access doc values would result in a UOE being thrown.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: panguixin <panguixin@bytedance.com>
@bugmakerrrrrr
Copy link
Contributor Author

@reta would you mind taking a look at this if you get a chance?

Signed-off-by: panguixin <panguixin@bytedance.com>
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch labels Nov 1, 2024
@reta reta added the v2.19.0 Issues and PRs related to version 2.19.0 label Nov 1, 2024
Signed-off-by: panguixin <panguixin@bytedance.com>
Copy link
Contributor

github-actions bot commented Nov 1, 2024

✅ Gradle check result for f300e31: SUCCESS

@reta reta merged commit a2a01f8 into opensearch-project:main Nov 1, 2024
38 of 39 checks passed
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.00%. Comparing base (0363aa7) to head (f300e31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16543      +/-   ##
============================================
- Coverage     72.00%   72.00%   -0.01%     
+ Complexity    65038    65030       -8     
============================================
  Files          5313     5313              
  Lines        303454   303460       +6     
  Branches      43910    43910              
============================================
- Hits         218510   218507       -3     
- Misses        67040    67067      +27     
+ Partials      17904    17886      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16543-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a2a01f821760f7f27eaf6d30b6a4daaadda9fec8
# Push it to GitHub
git push --set-upstream origin backport/backport-16543-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16543-to-2.x.

@reta
Copy link
Collaborator

reta commented Nov 1, 2024

ah @bugmakerrrrrr could you please backport to 2.x manually? thank you!

@dbwiddis
Copy link
Member

dbwiddis commented Nov 2, 2024

Changelog conflict. I think it just needed #16536 merged first. Will try toggling the backport label to see if it regenerates properly.

@dbwiddis dbwiddis added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch backport-failed labels Nov 2, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2024
* Support retrieving doc values of unsigned long field

Signed-off-by: panguixin <panguixin@bytedance.com>

* add test

Signed-off-by: panguixin <panguixin@bytedance.com>

* changelog

Signed-off-by: panguixin <panguixin@bytedance.com>

* randomize test

Signed-off-by: panguixin <panguixin@bytedance.com>

---------

Signed-off-by: panguixin <panguixin@bytedance.com>
(cherry picked from commit a2a01f8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Nov 2, 2024
* Support retrieving doc values of unsigned long field



* add test



* changelog



* randomize test



---------


(cherry picked from commit a2a01f8)

Signed-off-by: panguixin <panguixin@bytedance.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@bugmakerrrrrr bugmakerrrrrr deleted the ul_retrieve branch November 7, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch v2.19.0 Issues and PRs related to version 2.19.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants