Make entries for dependencies from server/build.gradle to gradle version catalog #16707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion catalog Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
❌ Gradle check result for 744698c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
commented
Nov 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16707 +/- ##
============================================
- Coverage 72.19% 72.06% -0.14%
+ Complexity 65274 65185 -89
============================================
Files 5318 5318
Lines 303993 303993
Branches 43990 43990
============================================
- Hits 219461 219065 -396
- Misses 66517 66982 +465
+ Partials 18015 17946 -69 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Craig Perkins <cwperx@amazon.com>
cwperks
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli and
shwetathareja
as code owners
reta
reviewed
Dec 4, 2024
buildSrc/src/main/groovy/org/opensearch/gradle/plugin/OptionalDependenciesPlugin.groovy
Outdated
Show resolved
Hide resolved
reta
reviewed
Dec 4, 2024
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
reta
approved these changes
Dec 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2024
…ion catalog (#16707) * Make entries for dependencies from server/build.gradle to gradle version catalog Signed-off-by: Craig Perkins <cwperx@amazon.com> * Handle NodeList Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> * Use wildcard Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add roaringbitmap Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 75a2fc3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ion catalog (#16707) (#16791) * Make entries for dependencies from server/build.gradle to gradle version catalog * Handle NodeList * Add CHANGELOG entry * Use wildcard * Add roaringbitmap --------- (cherry picked from commit 75a2fc3) Signed-off-by: Craig Perkins <cwperx@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR starts to expand on the gradle version catalog by defining the
[libraries]and[bundles]section of the version library. This starts to enable dependabot to make automated upgrades of these dependencies and makes managing bundles easier than managing bundles in individual build.gradle files.Related Issues
Follow-up to #16284
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.