Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate cleanup for Azure blob tests #16789

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented Dec 5, 2024

Description

Consolidate cleanup for Azure blob tests

Related Issues

Followup on #16778

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link
Contributor

github-actions bot commented Dec 5, 2024

❌ Gradle check result for 040691f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Dec 5, 2024

✅ Gradle check result for 040691f: SUCCESS

@reta
Copy link
Collaborator Author

reta commented Dec 5, 2024

@cwperks seems like we are good, @andrross @dblock mind please quick look? thanks!

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.07%. Comparing base (42dc22e) to head (040691f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16789      +/-   ##
============================================
+ Coverage     72.05%   72.07%   +0.02%     
- Complexity    65183    65188       +5     
============================================
  Files          5318     5318              
  Lines        303993   303993              
  Branches      43990    43990              
============================================
+ Hits         219028   219100      +72     
+ Misses        67046    66973      -73     
- Partials      17919    17920       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cwperks cwperks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Leaving a comment instead of marking as approved since I'm not a maintainer, but in the admin group.

@reta reta added the backport 2.x Backport to 2.x branch label Dec 5, 2024
@reta
Copy link
Collaborator Author

reta commented Dec 9, 2024

@dblock @andrross could you folks help me to get this one in? thank you

@andrross andrross merged commit 2d18c34 into opensearch-project:main Dec 9, 2024
66 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 9, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 2d18c34)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this pull request Dec 9, 2024
(cherry picked from commit 2d18c34)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants