Retrieve value from DocValues in a flat_object filed

[kkewwei]

Description

Added ability to retrieve value from DocValues in a flat_object filed

Related Issues

Resolves #16742

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for 31a060d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 6054295: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

❌ Gradle check result for 54cd837: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

SearchTimeoutIT.testSimpleTimeout #16056

[kkewwei]

@kkewwei -- I plan to review this PR this week. (Lots of meetings this week, but should have time Thursday or Friday.) Please @ me or bug me on OpenSearch Slack if I don't!

Thank you very much, some of the unit tests are not ready, I will fix soon and at you when all is ready.

TBR.

[github-actions]

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.26%. Comparing base (7050ecf) to head (cf49717).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java	54.54%	7 Missing and 3 partials ⚠️
...a/org/opensearch/index/mapper/DocValueFetcher.java	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16802      +/-   ##
============================================
+ Coverage     72.19%   72.26%   +0.06%     
- Complexity    65208    65253      +45     
============================================
  Files          5297     5297              
  Lines        303324   303347      +23     
  Branches      43913    43918       +5     
============================================
+ Hits         218999   219200     +201     
+ Misses        66367    66170     -197     
- Partials      17958    17977      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kkewwei]

❕ Gradle check result for a41d71e: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

SearchRestCancellationIT.testAutomaticCancellationDuringFetchPhase #14311

[kkewwei]

OpenSearch

@msfroh please have a look when you are free.

[github-actions]

❌ Gradle check result for 5714d79: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for d4cd439: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 237fce1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for cf49717: SUCCESS

[kkewwei]

@msfroh, please help to merge the pr when you are free.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-16802-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8ea0c80e90caee8fdbe161c9483ea7a6467b1b63
# Push it to GitHub
git push --set-upstream origin backport/backport-16802-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-16802-to-2.x.