Overflow prevention when handling date values #16812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvigodithi
force-pushed
the
long-overflow
branch
from
32ee21d to
8f297cb
Compare
prudhvigodithi
changed the title
prudhvigodithi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
VachaShah,
jainankitk and
linuxpi
as code owners
prudhvigodithi
requested review from
msfroh
and removed request for
jed326,
anasalkouz,
Rishikesh1159,
CEHENKLE and
gbbafna
|
Added a test based on similar scenario mentioned here #16709 (comment). |
|
❌ Gradle check result for 8f297cb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
prudhvigodithi
force-pushed
the
long-overflow
branch
from
8f297cb to
476ed76
Compare
msfroh
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Thanks, @prudhvigodithi ! The change makes sense to me. Good catch!
|
❌ Gradle check result for 476ed76: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
prudhvigodithi
force-pushed
the
long-overflow
branch
from
476ed76 to
79cc71a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16812 +/- ##
=========================================
Coverage 72.05% 72.05%
+ Complexity 65183 65140 -43
=========================================
Files 5318 5318
Lines 303993 304003 +10
Branches 43990 43992 +2
=========================================
+ Hits 219028 219043 +15
+ Misses 67046 66996 -50
- Partials 17919 17964 +45 ☔ View full report in Codecov by Sentry. |
bowenlan-amzn
approved these changes
Dec 9, 2024
andrross
reviewed
Dec 9, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
prudhvigodithi
force-pushed
the
long-overflow
branch
from
79cc71a to
0d6882e
Compare
andrross
approved these changes
Dec 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 5ba909a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
prudhvigodithi
pushed a commit
that referenced
this pull request
Dec 10, 2024
(cherry picked from commit 5ba909a) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mingshl
pushed a commit
to mingshl/OpenSearch-Mingshl
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
mingshl
pushed a commit
to mingshl/OpenSearch-Mingshl
that referenced
this pull request
Dec 16, 2024
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> Signed-off-by: Mingshi Liu <mingshl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from #16709 (comment) added a precaution to handle extreme date values during sorting to prevent
arithmetic_exception: long overflow.Related Issues
#16709 and #5713.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.