Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment version to 1.2.3 #1758

Merged
merged 2 commits into from
Dec 17, 2021
Merged

Increment version to 1.2.3 #1758

merged 2 commits into from
Dec 17, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 17, 2021

Signed-off-by: dblock dblock@amazon.com

Description

Coming from opensearch-project/opensearch-build#1365, increment version to 1.2.3.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock
Increment version to 1.2.3.
c0fee38 
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested review from peternied and a team December 17, 2021 00:29
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@dblock dblock mentioned this pull request Dec 17, 2021
Closed
38 tasks
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c0fee38
Log 1556

Reports 1556

@saratvemulapalli
Copy link
Member

I dont think I've seen this before.

> Task :server:test

Tests with failures:
 - org.opensearch.BuildTests.testEqualsAndHashCode

@dblock
Copy link
Member Author

dblock commented Dec 17, 2021

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c0fee38
Log 1563

Reports 1563

@dblock
Use a different version than 1.2.3 in the test.
f4e44a8 
Signed-off-by: dblock <dblock@dblock.org>
@dblock
Copy link
Member Author

dblock commented Dec 17, 2021

I dont think I've seen this before.

> Task :server:test

Tests with failures:
 - org.opensearch.BuildTests.testEqualsAndHashCode

Of course we would use 1.2.3 as an example in a test ...

@dblock
Copy link
Member Author

dblock commented Dec 17, 2021

start gradle check

@dblock dblock mentioned this pull request Dec 17, 2021
Merged
1 task
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success f4e44a8
Log 1566

Reports 1566

@dblock dblock merged commit dbc522f into opensearch-project:1.2 Dec 17, 2021
@dblock dblock deleted the 1.2.3 branch December 17, 2021 14:34
@dblock dblock mentioned this pull request Dec 28, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied approved these changes

@saratvemulapalli saratvemulapalli saratvemulapalli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dblock @opensearch-ci-bot @saratvemulapalli @peternied