Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Type parameter from TermVectors API #2104

Merged
merged 5 commits into from
Feb 15, 2022
Merged

[Remove] Type parameter from TermVectors API #2104

merged 5 commits into from
Feb 15, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Feb 14, 2022

Remove document type support from the TermVectors API.

Relates #1940

@nknize
[Remove] Type parameter from TermVectors API
766652d 
Remove document type support from the TermVectors API.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues labels Feb 14, 2022
@nknize nknize requested a review from a team as a code owner February 14, 2022 21:17
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 766652d
Log 2386

Reports 2386

@nknize
fix test failures
2222b38 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added the >breaking Identifies a breaking change. label Feb 15, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 2222b38
Log 2398

Reports 2398

@nknize
fix more failing tests
f996be6 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
temporarily mute MoreLikeThisIT.testMoreLikeThisMalformedArtificialDocs
587248a 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 587248a
Log 2400

Reports 2400

@nknize
pr feedback changes
6a23992 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize mentioned this pull request Feb 15, 2022
Closed
67 tasks
@nknize
Copy link
Collaborator Author

nknize commented Feb 15, 2022

Thank you @reta and @CEHENKLE!

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6a23992
Log 2413

Reports 2413

@nknize nknize merged commit c0c7d7a into opensearch-project:main Feb 15, 2022
@saratvemulapalli saratvemulapalli mentioned this pull request Mar 15, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CEHENKLE CEHENKLE CEHENKLE approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nknize @opensearch-ci-bot @reta @CEHENKLE