Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Types from GET/MGET #2168

Merged
merged 7 commits into from
Feb 21, 2022
Merged

[Remove] Types from GET/MGET #2168

merged 7 commits into from
Feb 21, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Feb 18, 2022 •
edited
Loading

This PR removes type support from the get and mget transport and rest actions along
with removal from ShardGetService.

relates #1940

@nknize nknize added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >breaking Identifies a breaking change. Indexing & Search labels Feb 18, 2022
@nknize nknize requested a review from a team as a code owner February 18, 2022 07:17
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9b6e19671d1b872b00ff21c8ad837b5dfd517382
Log 2563

Reports 2563

@nknize nknize mentioned this pull request Feb 18, 2022
Closed
67 tasks
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 21210c1df8ed08890c153dd46e6d39dc690cdd81
Log 2571

Reports 2571

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 938c39801aa7b796592a432442769ee488036db1
Log 2604

Reports 2604

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure f33c7731766bf11f5afededb85e0007fffc1a750
Log 2607

Reports 2607

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 310f9ea8c2282a34c106a63b3a71fdb3bde23ad7
Log 2610

Reports 2610

@nknize
[Remove] Types from GET/MGET
053f00f 
Removes type support from the get and mget transport and rest actions along
with removal from ShardGetService.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
fix test failures
57eb3d8 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
fix more failing tests w/ typos
c540dd4 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
Fix GetResultTests mutation
c00e0e9 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
more test failure fixes
1624b8d 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize
fix internalClusterTests
2173446 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize force-pushed the remove/typesFromGetMGet branch from 37e9e14 to 2173446 Compare February 18, 2022 23:06
@nknize
revert codec test
8c02c32 
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 2173446
Log 2611

Reports 2611

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8c02c32
Log 2612

Reports 2612

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022

Another docker failure:

> Task :distribution:docker:buildDockerImage FAILED
Exec output and error:
| Output for docker:Sending build context to Docker daemon  223.8MB

Refiring!

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8c02c32
Log 2620

Reports 2620

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022 •
edited
Loading

Non-reproducible random disconnect error already reported in #1828

./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=5222100ABDBA97B0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=es-PA -Dtests.timezone=Canada/Central -Druntime.java=17

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED
    java.util.concurrent.ExecutionException: MasterNotDiscoveredException[NodeDisconnectedException[[node_s1][127.0.0.1:46577][cluster:monitor/health] disconnected]]; nested: NodeDisconnectedException[[node_s1][127.0.0.1:46577][cluster:monitor/health] disconnected];
        at __randomizedtesting.SeedInfo.seed([5222100ABDBA97B0:CCCD3F27BE508B56]:0)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:281)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:268)
        at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:99)
        at org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover(ClusterHealthIT.java:393)

Refiring!

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 8c02c32
Log 2621

Reports 2621

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022

ANOTHER non reproducible flaky test failure already reported in #1746

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.gateway.RecoveryFromGatewayIT.testReuseInFileBasedPeerRecovery" -Dtests.seed=5D9018D9DB3A08DD -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-DZ -Dtests.timezone=America/Danmarkshavn -Druntime.java=17

org.opensearch.gateway.RecoveryFromGatewayIT > testReuseInFileBasedPeerRecovery FAILED
    java.lang.AssertionError: shard [test][0] on node [node_t1] has pending operations:
     --> RetentionLeaseBackgroundSyncAction.Request{retentionLeases=RetentionLeases{primaryTerm=1, version=1471, leases={peer_recovery/4ONFp4MdSgOm-e_3qIW5Fg=RetentionLease{id='peer_recovery/4ONFp4MdSgOm-e_3qIW5Fg', retainingSequenceNumber=846, timestamp=1645245603893, source='peer recovery'}, peer_recovery/J634nQ0wRaipZGI9GjlOZA=RetentionLease{id='peer_recovery/J634nQ0wRaipZGI9GjlOZA', retainingSequenceNumber=846, timestamp=1645245603893, source='peer recovery'}}}, shardId=[test][0], timeout=1m, index='test', waitForActiveShards=0}
    	at org.opensearch.index.shard.IndexShardOperationPermits.acquire(IndexShardOperationPermits.java:248)
    	at org.opensearch.index.shard.IndexShard.acquirePrimaryOperationPermit(IndexShard.java:3224)
    	at org.opensearch.action.support.replication.TransportReplicationAction.acquirePrimaryOperationPermit(TransportReplicationAction.java:1116)
    	at org.opensearch.action.support.replication.TransportReplicationAction$AsyncPrimaryAction.doRun(TransportReplicationAction.java:433)

@nknize
Copy link
Collaborator Author

nknize commented Feb 19, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8c02c32
Log 2622

Reports 2622

@nknize nknize merged commit 2e3f410 into opensearch-project:main Feb 21, 2022
reta
reta reviewed Feb 21, 2022
View reviewed changes
client/rest-high-level/src/test/java/org/opensearch/client/CrudIT.java
assertEquals("index", secondResponse.getIndex());
assertEquals("type", secondResponse.getType());
assertEquals("id2", secondResponse.getId());
multiGetRequest.add("index", "id2");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but the test name testMultiGetWithTypes() is not reflecting anymore what the test is doing, testMultiGetWithIds() ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nknize ^

@nknize nknize mentioned this pull request Feb 21, 2022
Merged
@saratvemulapalli saratvemulapalli mentioned this pull request Mar 15, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock left review comments

@reta reta reta left review comments

@dreamer-89 dreamer-89 dreamer-89 approved these changes

Assignees
No one assigned
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nknize @opensearch-ci-bot @reta @dblock @dreamer-89