Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate setting 'cluster.service.slow_master_task_logging_threshold' and introduce the alternative setting 'cluster.service.slow_cluster_manager_task_logging_threshold' #2451

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

tlfeng
Copy link
Collaborator

@tlfeng tlfeng commented Mar 14, 2022

Description

  • Add a new setting cluster.service.slow_cluster_manager_task_logging_threshold, aims to replace the existing cluster.service.slow_master_task_logging_threshold
  • Set the value of the old setting cluster.service.slow_master_task_logging_threshold as the fallback to the new setting
  • Deprecate the existing setting cluster.service.slow_master_task_logging_threshold
  • Add unit tests

Reference: commit 63c75d1 / PR #2221

Issues Resolved

Part of #1549

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@tlfeng tlfeng force-pushed the setting-slow_cluster_manager branch from 9a29930 to 49ad9bf Compare March 14, 2022 01:09
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 9a2993040c05735d4f0e3e9dc54f487695fcaee3
Log 3320

Reports 3320

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 49ad9bf
Log 3321

Reports 3321

@tlfeng tlfeng added enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0 documentation pending Tracks issues which have PRs merged but documentation changes pending labels Mar 14, 2022
@dblock dblock requested a review from kartg March 15, 2022 15:27
Tianli Feng added 2 commits March 15, 2022 21:32
…r_manager

Signed-off-by: Tianli Feng <ftianli@amazon.com>
…alue

Signed-off-by: Tianli Feng <ftianli@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success e9789b2
Log 3433

Reports 3433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation pending Tracks issues which have PRs merged but documentation changes pending enhancement Enhancement or improvement to existing feature or request v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants