Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Type Removal] Add mapping method referenced in other repos #2636

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Mar 28, 2022

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Add mapping method back; removed earlier as part of remove mapping types effort. The method was removed here. It is used in dashboard-reports repo and probably others.

Related: #1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested a review from a team as a code owner March 28, 2022 21:46
@dreamer-89 dreamer-89 requested a review from nknize March 28, 2022 21:55
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 97e04d2
Log 3832

Reports 3832

@dreamer-89
Copy link
Member Author

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover" -Dtests.seed=DC27A50FBE611B2F -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=fi -Dtests.timezone=Africa/Porto-Novo -Druntime.java=17

org.opensearch.cluster.ClusterHealthIT > testHealthOnMasterFailover FAILED
    java.util.concurrent.ExecutionException: MasterNotDiscoveredException[NodeDisconnectedException[[node_s2][127.0.0.1:38551][cluster:monitor/health] disconnected]]; nested: NodeDisconnectedException[[node_s2][127.0.0.1:38551][cluster:monitor/health] disconnected];
        at __randomizedtesting.SeedInfo.seed([DC27A50FBE611B2F:42C88A22BD8B07C9]:0)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.getValue(BaseFuture.java:281)
        at org.opensearch.common.util.concurrent.BaseFuture$Sync.get(BaseFuture.java:268)
        at org.opensearch.common.util.concurrent.BaseFuture.get(BaseFuture.java:99)
        at org.opensearch.cluster.ClusterHealthIT.testHealthOnMasterFailover(ClusterHealthIT.java:393)

        Caused by:
        MasterNotDiscoveredException[NodeDisconnectedException[[node_s2][127.0.0.1:38551][cluster:monitor/health] disconnected]]; nested: NodeDisconnectedException[[node_s2][127.0.0.1:38551][cluster:monitor/health] disconnected];
            at app//org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$2.onTimeout(TransportMasterNodeAction.java:275)
            at app//org.opensearch.cluster.ClusterStateObserver$ContextPreservingListener.onTimeout(ClusterStateObserver.java:369)
            at app//org.opensearch.cluster.ClusterStateObserver.waitForNextChange(ClusterStateObserver.java:174)
            at app//org.opensearch.cluster.ClusterStateObserver.waitForNextChange(ClusterStateObserver.java:142)
            at app//org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction.retry(TransportMasterNodeAction.java:258)
            at app//org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction.retryOnMasterChange(TransportMasterNodeAction.java:239)
            at app//org.opensearch.action.support.master.TransportMasterNodeAction$AsyncSingleAction$1.handleException(TransportMasterNodeAction.java:224)
            at app//org.opensearch.transport.TransportService$6.handleException(TransportService.java:735)
            at app//org.opensearch.transport.TransportService$ContextRestoreResponseHandler.handleException(TransportService.java:1350)
            at app//org.opensearch.transport.TransportService$9.run(TransportService.java:1207)
            at app//org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:733)
            at java.base@17.0.2/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
            at java.base@17.0.2/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
            at java.base@17.0.2/java.lang.Thread.run(Thread.java:833)

            Caused by:
            NodeDisconnectedException[[node_s2][127.0.0.1:38551][cluster:monitor/health] disconnected]

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 97e04d2
Log 3834

Reports 3834

@dreamer-89
Copy link
Member Author

REPRODUCE WITH: ./gradlew ':server:internalClusterTest' --tests "org.opensearch.search.SearchCancellationIT.testMSearchChildRequestCancellationWithClusterLevelTimeout" -Dtests.seed=2EAB86AB12D08AC5 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=el-CY -Dtests.timezone=SystemV/CST6 -Druntime.java=17

org.opensearch.search.SearchCancellationIT > testMSearchChildRequestCancellationWithClusterLevelTimeout FAILED
    java.lang.AssertionError: Actual child request with cancellation failure is different that expected expected:<[0, 1]> but was:<[]>
        at __randomizedtesting.SeedInfo.seed([2EAB86AB12D08AC5:90164D4E83C66AB2]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.failNotEquals(Assert.java:835)
        at org.junit.Assert.assertEquals(Assert.java:120)
        at org.opensearch.search.SearchCancellationIT.ensureMSearchWasCancelled(SearchCancellationIT.java:194)
        at org.opensearch.search.SearchCancellationIT.testMSearchChildRequestCancellationWithClusterLevelTimeout(SearchCancellationIT.java:537)

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 97e04d2
Log 3838

Reports 3838

@nknize nknize added Indexing & Search v3.0.0 Issues and PRs related to version 3.0.0 enhancement Enhancement or improvement to existing feature or request labels Mar 29, 2022
@nknize nknize merged commit bcaa06b into opensearch-project:main Mar 29, 2022
@nknize nknize added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Mar 29, 2022
nknize pushed a commit that referenced this pull request Mar 29, 2022
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

(cherry picked from commit bcaa06b)
nknize pushed a commit that referenced this pull request Mar 29, 2022
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

(cherry picked from commit bcaa06b)
kartg pushed a commit that referenced this pull request Mar 29, 2022
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

(cherry picked from commit bcaa06b)

Co-authored-by: Suraj Singh <79435743+dreamer-89@users.noreply.github.com>
kartg pushed a commit that referenced this pull request Mar 29, 2022
Signed-off-by: Suraj Singh <surajrider@gmail.com>
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>

(cherry picked from commit bcaa06b)

Co-authored-by: Suraj Singh <79435743+dreamer-89@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch enhancement Enhancement or improvement to existing feature or request Indexing & Search v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants