Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.0] Remove deprecation warning of using REST API request parameter 'master_timeout' #2931

Merged
merged 1 commit into from
Apr 16, 2022
Merged

[Backport 2.0] Remove deprecation warning of using REST API request parameter 'master_timeout' #2931

merged 1 commit into from
Apr 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8bc5765 from #2920

@github-actions
[2.x] Remove deprecation warning of using REST API request parameter …
681c29b 
…'master_timeout' (#2920)

The plan of deprecation parameter "master_timeout" changed to not show deprecation warning of 'master_timeout' parameter in 2.x version, but start to emit warning from version 3.0 .
For the detailed plan, see issue #2928.

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 8bc5765)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner April 15, 2022 22:48
@tlfeng tlfeng changed the title [Backport 2.0] [2.x] Remove deprecation warning of using REST API request parameter 'master_timeout' [Backport 2.0] Remove deprecation warning of using REST API request parameter 'master_timeout' Apr 15, 2022
@tlfeng tlfeng added v2.0.0 Version 2.0.0 backport PRs or issues specific to backporting features or enhancments deprecate labels Apr 15, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 681c29b
Log 4536

Reports 4536

@tlfeng
Copy link
Collaborator

tlfeng commented Apr 15, 2022 •
edited
Loading

In issue 4536:

> Task :qa:remote-clusters:integTest

REPRODUCE WITH: ./gradlew ':qa:remote-clusters:integTest' --tests "org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks" -Dtests.seed=4CFDAB007246BB9A -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=fi -Dtests.timezone=America/Atka -Druntime.java=17

org.opensearch.cluster.remote.test.RemoteClustersIT > testHAProxyModeConnectionWorks FAILED
    java.lang.AssertionError
        at __randomizedtesting.SeedInfo.seed([4CFDAB007246BB9A:4B8B7ECB49C0CDC7]:0)
        at org.junit.Assert.fail(Assert.java:87)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.junit.Assert.assertTrue(Assert.java:53)
        at org.opensearch.cluster.remote.test.RemoteClustersIT.testHAProxyModeConnectionWorks(RemoteClustersIT.java:125)

It's reported in #1703 . re-run: start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 681c29b
Log 4542

Reports 4542

@tlfeng tlfeng merged commit 1c799dd into 2.0 Apr 16, 2022
@github-actions github-actions bot deleted the backport/backport-2920-to-2.0 branch April 16, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng approved these changes

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments deprecate v2.0.0 Version 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @tlfeng