Add Delete Operations to Translog from Engine #2980
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
|
Same note as #2977 (comment) - please add javadocs for the new API Other than that, LGTM! |
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
|
start gradle check |
|
Note - we're holding off on pushing this as per #2977 (comment) |
nknize
requested changes
Apr 29, 2022
|
@Rishikesh1159 Any updates on this? Are you still blocked? |
|
Closing this PR. Changes necessary are added in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com
Description
This PR will allow us to decouple adding Delete operations to Lucene and adding Delete operations to Translog. This would be useful for segment replication, as we will need to just add delete operation to replicas translog instead of performing full delete operation. We will only use this method when segment replication is enabled and when we are on a replica node. The logic for checking if segment replication is enabled and is replica node will be added later in a different PR.
This is a part of the process of merging our feature branch - feature/segment-replication - back into main by re-PRing our changes from the feature branch.
The breakdown of the plan to merge to main is detailed here: #2926
For added context on segment replication - here's the design proposal #2229
Issues Resolved
#2926
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.