-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace internal usages of 'master' term in 'client' directory #3088
Merged
dblock
merged 2 commits into
opensearch-project:main
from
tlfeng:replace-master-int-client
Apr 27, 2022
Merged
Replace internal usages of 'master' term in 'client' directory #3088
dblock
merged 2 commits into
opensearch-project:main
from
tlfeng:replace-master-int-client
Apr 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Signed-off-by: Tianli Feng <ftianli@amazon.com>
Closed
12 tasks
tlfeng
added
v2.1.0
Issues and PRs related to version 2.1.0
backport 2.x
Backport to 2.x branch
labels
Apr 27, 2022
dblock
approved these changes
Apr 27, 2022
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-3088-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 dd7add25681b9fa206a92dceee97c69ca21948ef
# Push it to GitHub
git push --set-upstream origin backport/backport-3088-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
tlfeng
pushed a commit
to tlfeng/OpenSearch
that referenced
this pull request
May 11, 2022
…earch-project#3088) * Replace internal usages of 'master' term in 'client' directory Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add a uni test for NodeSelector to test deprecated master role Signed-off-by: Tianli Feng <ftianli@amazon.com>
5 tasks
Created PR #3284 to backport the change to |
dblock
pushed a commit
that referenced
this pull request
May 11, 2022
#3284) * Replace internal usages of 'master' term in 'client' directory Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add a uni test for NodeSelector to test deprecated master role Signed-off-by: Tianli Feng <ftianli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
client
directory.Replacement rules:
master
->cluster_manager
orclusterManager
(variable name) orcluster-manager
(code comment)Master
->ClusterManager
Issues Resolved
A part of #1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.