[2.x] Rename BecomeMasterTask to BecomeClusterManagerTask in JoinTaskExecutor (#3099) #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or (opensearch-project#3099) Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
added
v2.1.0
dblock
approved these changes
May 5, 2022
tlfeng
pushed a commit
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport PR #3099 / commit 017773c to
2.xbranch.There is a
ClusterStateTaskwith identifier_BECOME_MASTER_TASK_used to indicate the node to be the cluster manager node when joining the cluster.To support inclusive language, and finally change the "master" terminology, I made the following plan:
In version 2.0:
_BECOME_MASTER_TASK__BECOME_CLUSTER_MANAGER_TASK_isBecomeMasterTask()to accept the 2 namesIn version 3.0:
_BECOME_MASTER_TASK_The reason not change the name in-place:
The related methods are public methods, in case there are clients that call these method in a mixed version cluster of 1.x and 2.x, this way can keep the compatibility of using these methods with version 1.x cluster.
Issues Resolved
A part of #1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.