Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Replace internal usages of 'master' term in 'server/src/test' directory #3444

Merged
merged 1 commit into from
May 26, 2022
Merged

[Backport 2.x] Replace internal usages of 'master' term in 'server/src/test' directory #3444

merged 1 commit into from
May 26, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 296fa09 from #2520

@github-actions
Replace internal usages of 'master' term in 'server/src/test' directo…
1a910ee 
…ry (#2520)

* Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable/method/class names, in `server/src/test` directory.
* Backwards compatibility is not impacted.
* Add a new unit test `testDeprecatedMasterNodeFilter()` to validate using `master:true` or `master:false` can filter the node in [Cluster Stats](https://opensearch.org/docs/latest/opensearch/rest-api/cluster-stats/) API, after the `master` role is deprecated in PR #2424

Signed-off-by: Tianli Feng <ftianli@amazon.com>
(cherry picked from commit 296fa09)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners May 25, 2022 23:45
@tlfeng tlfeng added backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0 labels May 25, 2022
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 1a910ee
Log 5600

Reports 5600

@tlfeng tlfeng merged commit e88eaf6 into 2.x May 26, 2022
@github-actions github-actions bot deleted the backport/backport-2520-to-2.x branch May 26, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlfeng tlfeng tlfeng approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

Assignees
No one assigned
Labels
backport PRs or issues specific to backporting features or enhancments v2.1.0 Issues and PRs related to version 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opensearch-ci-bot @tlfeng