-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Rename to extensions #3951
Closed
mloufra
wants to merge
11
commits into
opensearch-project:feature/extensions
from
mloufra:feature/extensions
Closed
[Feature/extensions] Rename to extensions #3951
mloufra
wants to merge
11
commits into
opensearch-project:feature/extensions
from
mloufra:feature/extensions
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue # 28 Change the class name(plugin request, plugin response) and variable name.
saratvemulapalli
changed the title
Feature/extensions
[Feature/extensions] Rename to extensions
Jul 19, 2022
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
requested changes
Jul 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should be incorporated in sdk repo too otherwise the build will fail. Can you link the sdk PR in the description?
Signed-off-by: Ubuntu <ubuntu@ip-172-31-23-13.us-west-2.compute.internal>
…earch into feature/extensions
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: mloufra <mloufra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename method names, class names, variable names from plugin to extensions in the sdk codebase and related OpenSearch code
Equivalent PR on SDK: opensearch-project/opensearch-sdk-java#56
Issues Resolved
Rename plugin to extensions in the codebase #28
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.