Deprecate and Rename abstract methods from 'Master' terminology to 'ClusterManager'. #4032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terManager. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4032 +/- ##
============================================
- Coverage 70.65% 70.57% -0.08%
+ Complexity 56904 56897 -7
============================================
Files 4579 4582 +3
Lines 273780 273925 +145
Branches 40143 40158 +15
============================================
- Hits 193445 193336 -109
- Misses 64119 64334 +215
- Partials 16216 16255 +39
Help us with your feedback. Take ten seconds to tell us how you rate us. |
dreamer-89
approved these changes
Jul 28, 2022
tlfeng
added
enhancement
tlfeng
reviewed
Jul 28, 2022
| @@ -117,13 +117,24 @@ protected TransportClusterManagerNodeAction( | |||
|
|
|||
| protected abstract Response read(StreamInput in) throws IOException; | |||
|
|
|||
| protected abstract void masterOperation(Request request, ClusterState state, ActionListener<Response> listener) throws Exception; | |||
There was a problem hiding this comment.
@andrross Do you think we'd better add a comment in the code to remind adding back the abstract keyword after removing the deprecated method?
There was a problem hiding this comment.
Can we follow this up right after this is merged with a PR on main that removes the master methods and makes the methods abstract? If for some reason we can't do that then a comment is fine.
There was a problem hiding this comment.
I'm not sure we are going to remove the deprecated methods in version 3.0, which is the code in main branch, but I will write it down in to remind in issue #3542 or a new issue.
tlfeng
requested changes
Jul 28, 2022
...ain/java/org/opensearch/action/support/clustermanager/TransportClusterManagerNodeAction.java
Show resolved
Hide resolved
.../main/java/org/opensearch/action/support/clustermanager/info/TransportClusterInfoAction.java
Show resolved
Hide resolved
…them. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
tlfeng
approved these changes
Jul 30, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2022
…lusterManager'. (#4032) This commit deprecates and renames the following abstract methods: ``` In class TransportMasterNodeAction - abstract void masterOperation(Request request, ClusterState state, ActionListener listener) In class TransportClusterInfoAction - abstract void doMasterOperation(Request request, String[] concreteIndices, ClusterState state, ActionListener listener) In class TestCluster: public abstract int numDataAndMasterNodes(); ``` and the following concrete methods: ``` In class TransportMasterNodeAction - void masterOperation(Task task, Request request, ClusterState state, ActionListener<Response> listener) In class TransportClusterInfoAction - void masterOperation(final Request request, final ClusterState state, final ActionListener<Response> listener) ``` Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit 2a1b239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com
Description
This PR deprecates and renames the following abstract methods:
Issues Resolved
Part of #3542, #3544
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.