Rename classes with name 'MasterService' to 'ClusterManagerService' in directory 'test/framework' #4051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 29, 2022 20:53
…gerService Signed-off-by: Tianli Feng <ftianli@amazon.com>
…OnClusterManager Signed-off-by: Tianli Feng <ftianli@amazon.com>
…Disruption Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng
added
enhancement
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #4051 +/- ##
============================================
+ Coverage 70.50% 70.64% +0.13%
- Complexity 56848 56944 +96
============================================
Files 4583 4583
Lines 273931 273931
Branches 40158 40158
============================================
+ Hits 193146 193517 +371
+ Misses 64561 64135 -426
- Partials 16224 16279 +55
Help us with your feedback. Take ten seconds to tell us how you rate us. |
dreamer-89
approved these changes
Jul 30, 2022
|
@dreamer-89 Thank you so much for your rapid review! 🏅 |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
…n directory 'test/framework' (#4051) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. After the class MasterService has been deprecated and class ClusterManagerService has been created in #4022 / commit 740f75d, the classes in `test/framework` directory with name 'MasterService' can be deprecated and renamed. - Rename the following classes in `test/framework` directory: FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption In the following commit, I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility. Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit bea5d1a)
tlfeng
pushed a commit
that referenced
this pull request
Aug 1, 2022
…n directory 'test/framework' (#4051) (#4057) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. After the class MasterService has been deprecated and class ClusterManagerService has been created in #4022 / commit 740f75d, the classes in `test/framework` directory with name 'MasterService' can be deprecated and renamed. - Rename the following classes in `test/framework` directory: FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption In the following commit, I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility. Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit bea5d1a) Co-authored-by: Tianli Feng <ftianli@amazon.com>
5 tasks
tlfeng
pushed a commit
that referenced
this pull request
Aug 1, 2022
…er and BusyMasterServiceDisruption (#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR #4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <ftianli@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
…er and BusyMasterServiceDisruption (#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR #4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit cebeb8c)
tlfeng
pushed a commit
that referenced
this pull request
Aug 1, 2022
…er and BusyMasterServiceDisruption (#4058) (#4068) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR #4051 / commit bea5d1a, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <ftianli@amazon.com> (cherry picked from commit cebeb8c) Co-authored-by: Tianli Feng <ftianli@amazon.com>
pranikum
pushed a commit
to pranikum/OpenSearch
that referenced
this pull request
Aug 2, 2022
…er and BusyMasterServiceDisruption (opensearch-project#4058) To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base. In a previous PR opensearch-project#4051, 3 classes in `test/framework` directory that contains `master` in the name were renamed: ``` FakeThreadPoolMasterService -> FakeThreadPoolClusterManagerService BlockMasterServiceOnMaster -> BlockClusterManagerServiceOnClusterManager BusyMasterServiceDisruption -> BusyClusterManagerServiceDisruption ``` This is a following commit to add back the classes with the old name to keep the backwards compatibility. The classes with the old name will be subclass of the classes with new name, so that maintaining one implementation can support the usage for two classes. Signed-off-by: Tianli Feng <ftianli@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support inclusive language, the master terminology is going to be replaced by cluster manager in the code base.
After the class
MasterServicehas been deprecated and classClusterManagerServicehas been created in #4022 / commit 740f75d, the classes intest/frameworkdirectory with name 'MasterService' can be deprecated and renamed.test/frameworkdirectory:In the following PR (#4058), I will add back the above 3 classes with the old name and deprecate them, to keep the backwards compatibility.
Issues Resolved
A part of issue #3543
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.