Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Making shard copy count a multiple of attribute count (#3462) #4061

Closed

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Aug 1, 2022

  • Making all copies a multiple of attribute count

Signed-off-by: Gaurav Bafna gbbafna@amazon.com
(cherry picked from commit 82ff463)

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna gbbafna requested review from a team and reta as code owners August 1, 2022 05:58
@gbbafna gbbafna force-pushed the backport/backport-3462-to-2.x branch from 7487623 to 80c7029 Compare August 1, 2022 06:02
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna force-pushed the backport/backport-3462-to-2.x branch from 80c7029 to 928b8e9 Compare August 1, 2022 06:10
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

…ject#3462)

* Making all the copies a multiple of attribute count

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
(cherry picked from commit 82ff463)
@gbbafna gbbafna force-pushed the backport/backport-3462-to-2.x branch from 928b8e9 to ae15dec Compare August 1, 2022 17:11
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2022

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Aug 2, 2022

New PR : #4086

This branch had some rebasing issues. So raised a PR on a new branch .

@gbbafna gbbafna closed this Aug 2, 2022
@gbbafna gbbafna deleted the backport/backport-3462-to-2.x branch August 2, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant