issue #28 Rename to extensions #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
mloufra
force-pushed
the
feature2
branch
3 times, most recently
from
ae213d3 to
8a263eb
Compare
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## feature/extensions #4063 +/- ##
========================================================
- Coverage 70.64% 70.56% -0.09%
+ Complexity 57129 57074 -55
========================================================
Files 4612 4612
Lines 274811 274812 +1
Branches 40227 40227
========================================================
- Hits 194142 193921 -221
- Misses 64407 64643 +236
+ Partials 16262 16248 -14
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
ryanbogan
approved these changes
Aug 9, 2022
Signed-off-by: mloufra <mloufra@amazon.com>
Signed-off-by: mloufra <mloufra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
owaiskazi19
reviewed
Aug 9, 2022
| @@ -19,23 +19,23 @@ | |||
| import java.util.Objects; | |||
|
|
|||
| /** | |||
| * PluginRequest to intialize plugin | |||
| * InitializeExtensionsRequest to intialize plugin | |||
There was a problem hiding this comment.
Suggested change
| * InitializeExtensionsRequest to intialize plugin | |
| * InitializeExtensionsRequest to initialize extension |
owaiskazi19
reviewed
Aug 9, 2022
| @@ -40,18 +40,18 @@ | |||
| import java.util.Objects; | |||
|
|
|||
| /** | |||
| * PluginResponse to intialize plugin | |||
| * InitializeExtensionsResponse to intialize plugin | |||
There was a problem hiding this comment.
Suggested change
| * InitializeExtensionsResponse to intialize plugin | |
| * InitializeExtensionsResponse to initialize extension |
owaiskazi19
reviewed
Aug 9, 2022
server/src/main/java/org/opensearch/extensions/ExtensionsOrchestrator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mloufra <mloufra@amazon.com>
mloufra
force-pushed
the
feature2
branch
2 times, most recently
from
c51c292 to
9d8bc5d
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: mloufra <mloufra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: mloufra <mloufra@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mloufra mloufra@amazon.com
Description
Rename method names, class names, variable names from plugin to extensions in the sdk codebase and related OpenSearch code
Equivalent PR on SDK: opensearch-project/opensearch-sdk-java#72
Issues Resolved
opensearch-project/opensearch-sdk-java#28
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.