Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Add check to cancel ongoing replication with old primary on onNewCheckpoint on replica #4424

Merged

Conversation

dreamer-89
Copy link
Member

Manual backport of #4386 to 2.x

…port client (opensearch-project#4386)

* [Segment Replication] Extend FileChunkWriter to allow cancel on retryable transport client

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Add changelog entry

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Address review comments

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Integration test

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested review from a team and reta as code owners September 6, 2022 18:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #4424 (deffe54) into 2.x (fc97324) will increase coverage by 0.02%.
The diff coverage is 80.76%.

@@             Coverage Diff              @@
##                2.x    #4424      +/-   ##
============================================
+ Coverage     70.68%   70.71%   +0.02%     
+ Complexity    57182    57157      -25     
============================================
  Files          4584     4585       +1     
  Lines        274497   274494       -3     
  Branches      40226    40226              
============================================
+ Hits         194018   194095      +77     
+ Misses        64218    64184      -34     
+ Partials      16261    16215      -46     
Impacted Files Coverage Δ
...c/main/java/org/opensearch/index/IndexService.java 74.48% <0.00%> (+0.45%) ⬆️
...ndices/replication/OngoingSegmentReplications.java 93.05% <ø> (ø)
...ices/replication/RemoteSegmentFileChunkWriter.java 68.57% <0.00%> (-4.16%) ⬇️
...ch/indices/replication/CheckpointInfoResponse.java 47.05% <50.00%> (-0.57%) ⬇️
...search/index/shard/RemoteStoreRefreshListener.java 78.31% <60.00%> (-1.18%) ⬇️
...org/opensearch/cluster/metadata/IndexMetadata.java 84.00% <68.75%> (-0.31%) ⬇️
.../indices/replication/SegmentReplicationTarget.java 91.26% <85.71%> (+0.19%) ⬆️
...rc/main/java/org/opensearch/index/store/Store.java 81.55% <93.10%> (+1.26%) ⬆️
...pensearch/common/settings/IndexScopedSettings.java 100.00% <100.00%> (ø)
...org/opensearch/common/settings/SettingsModule.java 86.17% <100.00%> (ø)
... and 508 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Gradle Check (Jenkins) Run Completed with:

@dreamer-89 dreamer-89 merged commit 1f339e5 into opensearch-project:2.x Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants