add .worktrees/ to .gitignore
#4885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the `.worktrees/` folder is used in the guide for manual backporting as the location where to create the worktree for the backport branch. as this is inside of the repository the folder will be reported as an untracked file. to avoid this, i've now added it to `.gitignore`. though it might be better to create the worktree outside of the repository, the documentation on it doesn't comment explicitly on using it inside of the main worktree, however none of the examples do that. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Gradle Check (Jenkins) Run Completed with:
|
and another false reject... 😞 |
|
Maybe we should just change the instructions here? Seems like using worktrees outside the repository is the more normal practice. |
|
PR to change the backport instructions here: VachaShah/backport#5 |
|
superseded by the changes done to the backport suggestions => no longer needed |
6 tasks
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the
.worktrees/folder is used in the guide for manual backporting as the location where to create the worktree for the backport branch.as this is inside of the repository the folder will be reported as an untracked file. to avoid this, i've now added it to
.gitignore.though it might be better to create the worktree outside of the repository, the documentation on it doesn't comment explicitly on using it inside of the main worktree, however none of the examples do that.
Signed-off-by: Ralph Ursprung Ralph.Ursprung@avaloq.com
Description
see commit message. feel free to use this PR to instead discuss whether the worktrees shouldn't be managed outside of the repo instead (= changing the message for manual backports and maybe also the scripts for the automated backports if they also use this path).
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.