Fix: org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT is flaky. #5152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flaky. Signed-off-by: dblock <dblock@dblock.org>
andrross
approved these changes
Nov 8, 2022
Gradle Check (Jenkins) Run Completed with:
|
Poojita-Raj
pushed a commit
that referenced
this pull request
Nov 8, 2022
…hrottlingIT is flaky. (#5153) * Fix: org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT is flaky. (#5152) Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> (cherry picked from commit 88757b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix race condition in testThrottlingForSingleNode. Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dblock <dblock@dblock.org>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 9, 2022
…hrottlingIT is flaky. (#5153) * Fix: org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT is flaky. (#5152) Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> (cherry picked from commit 88757b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix race condition in testThrottlingForSingleNode. Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dblock <dblock@dblock.org> (cherry picked from commit 1cc50af) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
added a commit
that referenced
this pull request
Nov 9, 2022
…hrottlingIT is flaky. (#5153) (#5171) * Fix: org.opensearch.clustermanager.ClusterManagerTaskThrottlingIT is flaky. (#5152) Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> (cherry picked from commit 88757b4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Fix race condition in testThrottlingForSingleNode. Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dblock <dblock@dblock.org> (cherry picked from commit 1cc50af) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: dblock <dblock@dblock.org> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: dblock <dblock@dblock.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: dblock dblock@dblock.org
Description
The test creates a latch = number of requests, then every time a request finishes decrements the latch. For all failures it increments a counter. When the latch is at zero, it checks the counter. The counter was incremented after the latch was released, before the counter had a chance to be incremented one last time.
Issues Resolved
Closes #5083.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.