-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Weighted Shard Routing] API versioning #5255
[Weighted Shard Routing] API versioning #5255
Conversation
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
1e115f0
to
ffc638b
Compare
Unrelated test failures, building again |
Gradle Check (Jenkins) Run Completed with:
|
ffc638b
to
141298e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Don't see any issue opened for PIT test failures. I tried running the tests in my laptop, failures are happening in main branch as well, but its flaky because I could see a lot of builds passing, but somehow consistent failure in this PR
|
141298e
to
a7cb7eb
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5255 +/- ##
============================================
- Coverage 70.93% 70.48% -0.45%
+ Complexity 58713 58410 -303
============================================
Files 4767 4767
Lines 280162 280308 +146
Branches 40441 40473 +32
============================================
- Hits 198744 197587 -1157
- Misses 65199 66641 +1442
+ Partials 16219 16080 -139
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5255-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e0ddf524e705097a5e52ddbc9f7045680a38ffb2
# Push it to GitHub
git push --set-upstream origin backport/backport-5255-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
* Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
* Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
#5784) * [Weighted Routing] Add support for discovered master and remove local weights in the response (#5680) * Add support for discovered master and remove local weights in the weighted routing API response Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * [Weighted Shard Routing] API versioning (#5255) * Support API versioning for weighted shard routing Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * [Weighted Shard Routing] Fail open requests on search shard failures (#5072) * Fail open requests on search shard failures ( Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * Address fail open comments (#5778) [Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * remove unintended changes in changelog Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * remove unintended changes from changelog Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Signed-off-by: Anshu Agarwal <anshukag@amazon.com> Co-authored-by: Anshu Agarwal <anshukag@amazon.com>
…ed shard routing (#5781) * [Backport 2.x] [Weighted Shard Routing] Add support for discovered master and remove local weights in the response #5680 [Weighted Shard Routing] API versioning #5255 [Weighted Shard Routing] Fail open requests on search shard failures #5072 [Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting #5778 Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
…ed shard routing (#5781) * [Backport 2.x] [Weighted Shard Routing] Add support for discovered master and remove local weights in the response #5680 [Weighted Shard Routing] API versioning #5255 [Weighted Shard Routing] Fail open requests on search shard failures #5072 [Weighted Shard Routing] Refactor and fix singleton in FailAwareWeightedRouting #5778 Signed-off-by: Anshu Agarwal <anshukag@amazon.com>
Signed-off-by: Anshu Agarwal anshukag@amazon.com
Description
This PR adds support for versioning weighted routing apis. PUT and GET is versioned in this PR.
Issues Resolved
#5038
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.