Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added getSettings() support, ActionListener onFailure(), and initial createComponents support for extensions #5597

Conversation

ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Dec 18, 2022

Signed-off-by: Ryan Bogan rbogan@amazon.com

Description

This PR merges the third batch of feature/extensions into main and will then be backported to 2.x. It adds getSettings() support, ActionListener onFailure(), and initial createComponents support.

Issues Resolved

Issue with links to PR's included in this merge: #5272
Meta issue for entire feature/extensions merge: #5263

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…createComponents support for extensions

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #5597 (a66cfd5) into main (0f520f6) will decrease coverage by 0.00%.
The diff coverage is 72.50%.

@@             Coverage Diff              @@
##               main    #5597      +/-   ##
============================================
- Coverage     71.02%   71.01%   -0.01%     
- Complexity    58403    58443      +40     
============================================
  Files          4741     4748       +7     
  Lines        278535   278812     +277     
  Branches      40268    40296      +28     
============================================
+ Hits         197819   197988     +169     
- Misses        64509    64637     +128     
+ Partials      16207    16187      -20     
Impacted Files Coverage Δ
...va/org/opensearch/extensions/ExtensionRequest.java 29.41% <ø> (ø)
...arch/extensions/UpdateSettingsResponseHandler.java 0.00% <0.00%> (ø)
...rch/extensions/rest/RestSendToExtensionAction.java 27.77% <ø> (ø)
...a/org/opensearch/extensions/ExtensionsManager.java 55.85% <31.57%> (-4.90%) ⬇️
...rg/opensearch/env/EnvironmentSettingsResponse.java 60.00% <60.00%> (ø)
...g/opensearch/extensions/UpdateSettingsRequest.java 63.33% <63.33%> (ø)
...sions/AddSettingsUpdateConsumerRequestHandler.java 65.21% <65.21%> (ø)
...nsions/settings/RegisterCustomSettingsRequest.java 77.77% <77.77%> (ø)
...h/extensions/AddSettingsUpdateConsumerRequest.java 79.31% <79.31%> (ø)
...g/opensearch/common/settings/WriteableSetting.java 93.45% <93.45%> (ø)
... and 479 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ryanbogan
Copy link
Member Author

@dblock @reta would love your feedback on this when you get a chance

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      2 org.opensearch.cluster.service.MasterServiceTests.classMethod
      1 org.opensearch.recovery.RecoveryWhileUnderLoadIT.testRecoverWhileUnderLoadWithReducedAllowedNodes
      1 org.opensearch.recovery.RecoveryWhileUnderLoadIT.testRecoverWhileUnderLoadAllocateReplicasRelocatePrimariesTest
      1 org.opensearch.recovery.RecoveryWhileUnderLoadIT.testRecoverWhileRelocating
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes
      1 org.opensearch.cluster.service.MasterServiceTests.testThrottlingForMultipleTaskTypes

@ryanbogan
Copy link
Member Author

@reta I believe all of your suggestions have been addressed and the PR is ready for your review again - thanks for the feedback!

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan
Copy link
Member Author

@reta All comments are addressed again. The PR is ready for your re-review.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=search.aggregation/20_terms/string profiler via global ordinals}

@reta
Copy link
Collaborator

reta commented Dec 22, 2022

@reta All comments are addressed again. The PR is ready for your re-review.

Thanks @ryanbogan , I have only 2 concerns: #5597 (comment) and #5597 (comment) (I believe we could improve there)

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@ryanbogan
Copy link
Member Author

@reta Both concerns are addressed now.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Dec 22, 2022

@reta Both concerns are addressed now.

@ryanbogan LGTM, thanks for working this through, I would appreciate second pair of eyes (@owaiskazi19 @dbwiddis) since this pull request is certainly part of larger change.

@owaiskazi19 owaiskazi19 requested a review from reta December 23, 2022 00:45
@owaiskazi19 owaiskazi19 merged commit da94dbb into opensearch-project:main Dec 23, 2022
@ryanbogan ryanbogan added the backport 2.x Backport to 2.x branch label Dec 23, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5597-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da94dbb94e16a9766049006e666b02dd89b5bf7e
# Push it to GitHub
git push --set-upstream origin backport/backport-5597-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5597-to-2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants