-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added getSettings() support, ActionListener onFailure(), and initial createComponents support for extensions #5597
Added getSettings() support, ActionListener onFailure(), and initial createComponents support for extensions #5597
Conversation
…createComponents support for extensions Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #5597 +/- ##
============================================
- Coverage 71.02% 71.01% -0.01%
- Complexity 58403 58443 +40
============================================
Files 4741 4748 +7
Lines 278535 278812 +277
Branches 40268 40296 +28
============================================
+ Hits 197819 197988 +169
- Misses 64509 64637 +128
+ Partials 16207 16187 -20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
server/src/main/java/org/opensearch/common/settings/WriteableSetting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/settings/WriteableSetting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/env/EnvironmentSettingsResponse.java
Outdated
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
@reta I believe all of your suggestions have been addressed and the PR is ready for your review again - thanks for the feedback! |
server/src/main/java/org/opensearch/common/settings/WriteableSetting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/settings/WriteableSetting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/extensions/ExtensionActionListener.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/common/settings/WriteableSetting.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/env/EnvironmentSettingsResponse.java
Show resolved
Hide resolved
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@reta All comments are addressed again. The PR is ready for your re-review. |
Gradle Check (Jenkins) Run Completed with:
|
Thanks @ryanbogan , I have only 2 concerns: #5597 (comment) and #5597 (comment) (I believe we could improve there) |
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Ryan Bogan <rbogan@amazon.com>
@reta Both concerns are addressed now. |
Gradle Check (Jenkins) Run Completed with:
|
@ryanbogan LGTM, thanks for working this through, I would appreciate second pair of eyes (@owaiskazi19 @dbwiddis) since this pull request is certainly part of larger change. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-5597-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 da94dbb94e16a9766049006e666b02dd89b5bf7e
# Push it to GitHub
git push --set-upstream origin backport/backport-5597-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
Signed-off-by: Ryan Bogan rbogan@amazon.com
Description
This PR merges the third batch of feature/extensions into main and will then be backported to 2.x. It adds getSettings() support, ActionListener onFailure(), and initial createComponents support.
Issues Resolved
Issue with links to PR's included in this merge: #5272
Meta issue for entire feature/extensions merge: #5263
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.