Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix flaky SearchCancellationIT tests to avoid race condition #5657

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d248643 from #5656.

* Add waiting time to account for Thread.sleep inaccuracy

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit d248643)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #5657 (d248643) into 2.x (f8da145) will increase coverage by 0.33%.
The diff coverage is 51.02%.

❗ Current head d248643 differs from pull request most recent head 917c672. Consider uploading reports for the commit 917c672 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #5657      +/-   ##
============================================
+ Coverage     70.59%   70.93%   +0.33%     
+ Complexity    58605    58578      -27     
============================================
  Files          4740     4760      +20     
  Lines        280514   279515     -999     
  Branches      40881    40348     -533     
============================================
+ Hits         198019   198263     +244     
+ Misses        65962    65098     -864     
+ Partials      16533    16154     -379     
Impacted Files Coverage Δ
...ark/time/NanoTimeVsCurrentTimeMillisBenchmark.java 0.00% <0.00%> (ø)
...nsearch/gradle/precommit/LicenseHeadersTask.groovy 0.00% <ø> (ø)
.../java/org/opensearch/gradle/JdkDownloadPlugin.java 36.26% <0.00%> (-1.10%) ⬇️
...rg/opensearch/gradle/OpenSearchTestBasePlugin.java 6.81% <0.00%> (-0.25%) ⬇️
...ternal/InternalDistributionArchiveCheckPlugin.java 0.00% <0.00%> (ø)
...ternal/InternalDistributionArchiveSetupPlugin.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/FilePermissionsTask.java 78.78% <ø> (ø)
...search/gradle/precommit/ForbiddenPatternsTask.java 88.40% <ø> (ø)
...g/opensearch/gradle/precommit/LoggerUsageTask.java 0.00% <ø> (ø)
...ensearch/gradle/precommit/ThirdPartyAuditTask.java 0.00% <0.00%> (ø)
... and 1028 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit b9222d1 into 2.x Dec 29, 2022
@github-actions github-actions bot deleted the backport/backport-5656-to-2.x branch December 29, 2022 21:24
kotwanikunal pushed a commit that referenced this pull request Jan 25, 2023
…5657)

* Add waiting time to account for Thread.sleep inaccuracy

Signed-off-by: Daniel Widdis <widdis@gmail.com>
(cherry picked from commit d248643)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants