Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions] Changing ExtensionActionRequest streaminput constructor to be public #6094

Merged
merged 3 commits into from
Jan 30, 2023
Merged

[Extensions] Changing ExtensionActionRequest streaminput constructor to be public #6094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
95bf5b8
Changing ExtensionActionRequest streaminput constructor to be public
joshpalis Jan 30, 2023
b835c1d
Updating changelog
joshpalis Jan 30, 2023
af06848
Moving changelog entry to unreleased 2.x
joshpalis Jan 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Replace latches with CompletableFutures for extensions ([#5646](https://github.com/opensearch-project/OpenSearch/pull/5646))
- Add GeoTile and GeoHash Grid aggregations on GeoShapes. ([#5589](https://github.com/opensearch-project/OpenSearch/pull/5589))
- Add support to disallow search request with preference parameter with strict weighted shard routing([#5874](https://github.com/opensearch-project/OpenSearch/pull/5874))
- Changing ExtensionActionRequest streaminput constructor to be public ([#6094](https://github.com/opensearch-project/OpenSearch/pull/6094))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need a changelog entry for a change like this. Honestly all we really need is a single entry linking to the top-level issue that describes the new extensions feature and not an entry for every incremental PR.


### Dependencies
- Update nebula-publishing-plugin to 19.2.0 ([#5704](https://github.com/opensearch-project/OpenSearch/pull/5704))
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/extensions/action/ExtensionActionRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ public ExtensionActionRequest(String action, byte[] requestBytes) {
* @param in bytes stream input used to de-serialize the message.
* @throws IOException when message de-serialization fails.
*/
ExtensionActionRequest(StreamInput in) throws IOException {
public ExtensionActionRequest(StreamInput in) throws IOException {
super(in);
action = in.readString();
requestBytes = in.readByteArray();
Expand Down