[Extensions] Changing ExtensionActionRequest streaminput constructor to be public #6101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Palis <jpalis@amazon.com>
joshpalis
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Signed-off-by: Joshua Palis <jpalis@amazon.com>
saratvemulapalli
approved these changes
Jan 31, 2023
andrross
reviewed
Jan 31, 2023
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
| - Replace latches with CompletableFutures for extensions ([#5646](https://github.com/opensearch-project/OpenSearch/pull/5646)) | |||
| - Add support to disallow search request with preference parameter with strict weighted shard routing([#5874](https://github.com/opensearch-project/OpenSearch/pull/5874)) | |||
| - Added support to apply index create block ([#4603](https://github.com/opensearch-project/OpenSearch/issues/4603)) | |||
| - Changing ExtensionActionRequest streaminput constructor to be public ([#6101](https://github.com/opensearch-project/OpenSearch/pull/6101)) | |||
There was a problem hiding this comment.
See #6094 (comment), but I don't think we need a changelog entry for these types of changes.
There was a problem hiding this comment.
ill go ahead and remove this
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 2.x #6101 +/- ##
============================================
+ Coverage 70.42% 70.48% +0.05%
+ Complexity 59007 58965 -42
============================================
Files 4771 4771
Lines 282733 282733
Branches 41179 41179
============================================
+ Hits 199121 199277 +156
+ Misses 66994 66752 -242
- Partials 16618 16704 +86
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
ryanbogan
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joshua Palis jpalis@amazon.com
Description
Manual backport PR to 2.x due to backport failure here : #6094 (comment)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.