-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated org.gradle.util.DistributionLocator usage #6212
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #6212 +/- ##
============================================
- Coverage 70.73% 70.70% -0.04%
+ Complexity 59024 58968 -56
============================================
Files 4800 4799 -1
Lines 282453 282421 -32
Branches 40718 40717 -1
============================================
- Hits 199799 199691 -108
- Misses 66259 66330 +71
- Partials 16395 16400 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
@dbwiddis could you rebase please? the Gradle's wrapper bits are not needed anymore (we are on 8.0 now), but the dropping |
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Signed-off-by: Daniel Widdis <widdis@gmail.com>
80aeaab
to
db7f8fd
Compare
Gradle Check (Jenkins) Run Completed with:
|
45b3107
to
91700c7
Compare
Done! |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Daniel Widdis <widdis@gmail.com>
Gradle Check (Jenkins) Run Completed with:
|
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-6212-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 36f5cfe807584177dd4842810734e04a5f7bd4ae
# Push it to GitHub
git push --set-upstream origin backport/backport-6212-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x Then, create a pull request where the |
@dbwiddis backport to 2.x failed :( could you please do it manually? thank you! |
…ch-project#6212) * Remove deprecated org.gradle.util.DistributionLocator usage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update gradle wrapper version to test no deprecation warning Signed-off-by: Daniel Widdis <widdis@gmail.com> * Change log Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add newline so linelint doesn't complain. Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove remove typo typo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use wrapper getDistributionUrl method Signed-off-by: Daniel Widdis <widdis@gmail.com> * Restore license header removed by autogeneration Signed-off-by: Daniel Widdis <widdis@gmail.com> * Gradle 8 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Revert minimumGradleVersion change Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 36f5cfe)
…6377) * Remove deprecated org.gradle.util.DistributionLocator usage Signed-off-by: Daniel Widdis <widdis@gmail.com> * Update gradle wrapper version to test no deprecation warning Signed-off-by: Daniel Widdis <widdis@gmail.com> * Change log Signed-off-by: Daniel Widdis <widdis@gmail.com> * Add newline so linelint doesn't complain. Signed-off-by: Daniel Widdis <widdis@gmail.com> * Remove remove typo typo Signed-off-by: Daniel Widdis <widdis@gmail.com> * Use wrapper getDistributionUrl method Signed-off-by: Daniel Widdis <widdis@gmail.com> * Restore license header removed by autogeneration Signed-off-by: Daniel Widdis <widdis@gmail.com> * Gradle 8 Signed-off-by: Daniel Widdis <widdis@gmail.com> * Revert minimumGradleVersion change Signed-off-by: Daniel Widdis <widdis@gmail.com> --------- Signed-off-by: Daniel Widdis <widdis@gmail.com> (cherry picked from commit 36f5cfe)
Description
The org.gradle.util.DistributionLocator class is deprecated and will be removed in Gradle 9.0.
This PR replaces that usage in
build.gradle
withwrapper.getDistributionUrl()
which implements the identical logic internally (and is not deprecated).Also added a new line to the min version generation so linelint doesn't complain. :-)
Initial commit only changed
build.gradle
. Testing the repro case in the linked issue below also upgraded the minimum gradle version to 7.6, which is a good thing as it is required for JDK19+ compatibility.Issues Resolved
Fixes #5494
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.