[Backport 2.x] [Segment Replication] Update RefreshPolicy.WAIT_UNTIL for replica shards with segment replication enabled to wait for replica refresh #6612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…rds with segment replication enabled to wait for replica refresh (#6464) * Initial draft PR for wait_until with segrep Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Refactor code and fix test failures. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * add comments and fix tests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Refactor code, address comments and fix test failures. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Aplly spotless check Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adress comments and add integ test. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Address comments and fix failing tests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fixing failing test. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Remove unused code. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments and refactoring Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding max refreshlisteners limit that a replica shard can hold and force refresh. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Changing assert message Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix call to release refresh listeners on replica shards. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix call to release refresh listeners on replica shards. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Address comments. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fixing compile errors. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Spoltss Apply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> --------- Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> (cherry picked from commit e8a4210) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
adnapibar,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
|
The commit to main have been reverted (#6622) so I'm closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e8a4210 from #6464.