[Segment Replication] Fix flaky tests in SegmentReplicationPressureIT #6868
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Poojita Raj <poojiraj@amazon.com>
Poojita-Raj
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
xuezhou25
as code owners
Rishikesh1159
approved these changes
Mar 29, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 29, 2023
Signed-off-by: Poojita Raj <poojiraj@amazon.com> (cherry picked from commit 7b708c4) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dreamer-89
pushed a commit
that referenced
this pull request
Mar 29, 2023
(cherry picked from commit 7b708c4) Signed-off-by: Poojita Raj <poojiraj@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159
added a commit
to Rishikesh1159/OpenSearch
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the previous tests for segmentReplicationPressureIT, the tests covered situations where it expected replicas to be stale and fail behind. However, it didn't take automatic background refreshes that take place at a refresh interval into account. Therefore, in certain situations where we expected the replica to be only 1 or 2 checkpoints behind due to indexing docs, it was actually 3 or 4 checkpoints behind due to checkpoints being sent on automatic refresh as well.
This caused all the replicas to turn stale and the tests to fail intermittently. By turning off the automatic refresh, we now control when we expect the refreshes to take place which fixes the issue. Ran the tests over 2000 times to check with no failures.
Issues Resolved
Resolves #6671
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.