Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure path is set before trying to parse using %~nxI #7079

Closed

Conversation

stephen-crawford
Copy link
Contributor

@stephen-crawford stephen-crawford commented Apr 10, 2023

Description

Resolve the issue seen as a result of #6956.

Issues Resolved

Security and Job Scheduler failures amongst other repos.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2023

Codecov Report

Merging #7079 (16112c3) into main (3ba333b) will decrease coverage by 0.23%.
The diff coverage is 53.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7079      +/-   ##
============================================
- Coverage     70.77%   70.55%   -0.23%     
+ Complexity    59367    59352      -15     
============================================
  Files          4825     4852      +27     
  Lines        284369   285148     +779     
  Branches      41021    41109      +88     
============================================
- Hits         201263   201177      -86     
- Misses        66603    67442     +839     
- Partials      16503    16529      +26     
Impacted Files Coverage Δ
...search/client/SearchPipelineRequestConverters.java 0.00% <0.00%> (ø)
...eline/common/SearchPipelineCommonModulePlugin.java 0.00% <0.00%> (ø)
...ion/admin/cluster/node/info/NodesInfoResponse.java 3.03% <0.00%> (-0.10%) ⬇️
...search/action/search/GetSearchPipelineRequest.java 0.00% <0.00%> (ø)
...earch/action/search/GetSearchPipelineResponse.java 0.00% <0.00%> (ø)
.../org/opensearch/client/support/AbstractClient.java 31.10% <0.00%> (-0.66%) ⬇️
...search/cluster/service/ClusterManagerTaskKeys.java 0.00% <ø> (ø)
...pensearch/common/settings/FeatureFlagSettings.java 50.00% <ø> (ø)
...a/org/opensearch/plugins/SearchPipelinePlugin.java 0.00% <0.00%> (ø)
.../action/search/RestDeleteSearchPipelineAction.java 0.00% <0.00%> (ø)
... and 37 more

... and 502 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@peterzhuamazon
Copy link
Member

Talked to @scrawfor99 offline as I have a tested solution with @vamsi-amazon.
Will raise PR.

Close this now.

Thanks.

@stephen-crawford stephen-crawford deleted the fix-script branch April 11, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants