Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Integrate S3 async upload with S3BlobContainer #7218

Merged

Conversation

raghuvanshraj
Copy link
Contributor

@raghuvanshraj raghuvanshraj commented Apr 18, 2023

Credits: @vikasvb90 and @itiyamas for the design and core implementations of the feature.

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from bab15f9 to 4f2ded6 Compare May 4, 2023 06:53
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Gradle Check (Jenkins) Run Completed with:

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 4f2ded6 to 63a99d3 Compare May 24, 2023 15:53
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@raghuvanshraj raghuvanshraj changed the title Integrating S3 async upload with S3BlobContainer [Remote Store] Integrating S3 async upload with S3BlobContainer May 25, 2023
@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 63a99d3 to 096d08d Compare May 25, 2023 09:06
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #7218 (45b3294) into main (6a35ffa) will increase coverage by 0.02%.
The diff coverage is 48.83%.

@@             Coverage Diff              @@
##               main    #7218      +/-   ##
============================================
+ Coverage     70.91%   70.94%   +0.02%     
- Complexity    57093    57195     +102     
============================================
  Files          4770     4770              
  Lines        270199   270276      +77     
  Branches      39496    39499       +3     
============================================
+ Hits         191604   191736     +132     
- Misses        62371    62401      +30     
+ Partials      16224    16139      -85     
Impacted Files Coverage Δ
...opensearch/repositories/s3/S3RepositoryPlugin.java 0.00% <0.00%> (ø)
...va/org/opensearch/repositories/s3/S3BlobStore.java 85.71% <69.23%> (-6.40%) ⬇️
...rg/opensearch/repositories/s3/S3BlobContainer.java 80.06% <85.18%> (+3.78%) ⬆️
...a/org/opensearch/repositories/s3/S3Repository.java 84.72% <100.00%> (+2.18%) ⬆️

... and 482 files with indirect coverage changes

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 096d08d to 0e3a3e4 Compare May 29, 2023 12:59
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: null ❌
  • URL: null
  • CommitID: 0e3a3e4
    Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
    Is the failure a flaky test unrelated to your change?

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 0e3a3e4 to 4b2fc3b Compare June 5, 2023 10:53
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity. Remove stalled label or comment or this will be closed in 7 days.

@opensearch-trigger-bot opensearch-trigger-bot bot added the stalled Issues that have stalled label Jul 5, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot removed the stalled Issues that have stalled label Jul 6, 2023
@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 4b2fc3b to 5f63ced Compare July 7, 2023 12:23
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 5f63ced to c23162b Compare July 7, 2023 13:06
@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Gradle Check (Jenkins) Run Completed with:

@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from bf6fae4 to c23162b Compare July 10, 2023 09:00
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationRelocationIT.testPrimaryRelocationWithSegRepFailure

Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 9eddd07 to 9d68844 Compare July 13, 2023 03:10
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
@raghuvanshraj raghuvanshraj force-pushed the multi-part-upload-plugin-pr-3 branch from 9d68844 to 45b3294 Compare July 13, 2023 03:20
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testDropPrimaryDuringReplication

@gbbafna gbbafna changed the title [Remote Store] Integrating S3 async upload with S3BlobContainer [Remote Store] Integrate S3 async upload with S3BlobContainer Jul 13, 2023
@gbbafna gbbafna merged commit 2f4545a into opensearch-project:main Jul 13, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jul 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7218-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f4545aafef5f76103574c4a343a68bf54cac7a1
# Push it to GitHub
git push --set-upstream origin backport/backport-7218-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7218-to-2.x.

@raghuvanshraj raghuvanshraj added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Jul 13, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-7218-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2f4545aafef5f76103574c4a343a68bf54cac7a1
# Push it to GitHub
git push --set-upstream origin backport/backport-7218-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7218-to-2.x.

@raghuvanshraj
Copy link
Contributor Author

Backport is failing due to #8157
We need to first backport the above mentioned PR, then backport this one to avoid failures in 2.x.

raghuvanshraj added a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 13, 2023
@raghuvanshraj
Copy link
Contributor Author

raghuvanshraj commented Jul 13, 2023

Raised manual backport to 2.x: #8676

raghuvanshraj added a commit to raghuvanshraj/OpenSearch that referenced this pull request Jul 13, 2023
gbbafna pushed a commit that referenced this pull request Jul 13, 2023
…#8676)

Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
buddharajusahil pushed a commit to buddharajusahil/OpenSearch that referenced this pull request Jul 18, 2023
…arch-project#7218)

Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: sahil buddharaju <sahilbud@amazon.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…arch-project#7218)

Signed-off-by: Raghuvansh Raj <raghraaj@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants