Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved flat object from changed to added b/c it's new #7322

Merged
merged 3 commits into from
Apr 29, 2023

Conversation

macohen
Copy link
Contributor

@macohen macohen commented Apr 28, 2023

Description

moves flat object from the changed to added section. didn't think this was notable enough for CHANGELOG.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • [ x ] Commits are signed per the DCO using --signoff
  • [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…le more description

Signed-off-by: Mark Cohen <markcoh@amazon.com>
@@ -21,6 +21,7 @@
- Add retry delay as dynamic setting for cluster maanger throttling. ([#6998](https://github.com/opensearch-project/OpenSearch/pull/6998))
- Introduce full support for searchable snapshots ([#5087](https://github.com/opensearch-project/OpenSearch/issues/5087))
- Introduce full support for Segment Replication ([#5147](https://github.com/opensearch-project/OpenSearch/issues/5147))
- Introduce a new field type: flat_object to help prevent mapping explosions ([#6507](https://github.com/opensearch-project/OpenSearch/pull/6507))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about linking to the original issue here instead of the PR? That's probably a better resource to learn about the feature than the PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart. done.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testIndexDeletionDuringSnapshotCreationInQueue

@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Merging #7322 (f8af1f4) into main (b752555) will decrease coverage by 0.14%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main    #7322      +/-   ##
============================================
- Coverage     70.71%   70.57%   -0.14%     
+ Complexity    59516    59479      -37     
============================================
  Files          4859     4859              
  Lines        285369   285369              
  Branches      41134    41134              
============================================
- Hits         201801   201411     -390     
- Misses        66956    67381     +425     
+ Partials      16612    16577      -35     

see 478 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@andrross andrross merged commit 0d22fda into opensearch-project:main Apr 29, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2023
* moved flat object from changed to added b/c it's new and added a little more description

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* switch flat object line to the issue instead of the PR

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
(cherry picked from commit 0d22fda)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2023
* moved flat object from changed to added b/c it's new and added a little more description

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* switch flat object line to the issue instead of the PR

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
(cherry picked from commit 0d22fda)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request May 1, 2023
* moved flat object from changed to added b/c it's new and added a little more description



* switch flat object line to the issue instead of the PR



---------


(cherry picked from commit 0d22fda)

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock pushed a commit that referenced this pull request May 1, 2023
* moved flat object from changed to added b/c it's new and added a little more description



* switch flat object line to the issue instead of the PR



---------


(cherry picked from commit 0d22fda)

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ect#7322)

* moved flat object from changed to added b/c it's new and added a little more description

Signed-off-by: Mark Cohen <markcoh@amazon.com>

* switch flat object line to the issue instead of the PR

Signed-off-by: Mark Cohen <markcoh@amazon.com>

---------

Signed-off-by: Mark Cohen <markcoh@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants