-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Search Pipelines] Split search pipeline processor factories by type #7669
[Backport 2.x] [Search Pipelines] Split search pipeline processor factories by type #7669
Conversation
…pensearch-project#7597) In the initial search pipelines commit, I threw request and response processor factories into one combined map. I think that was a mistake. We should embrace type-safety by making sure that the kind of processor is clear from end to end. As we add more processor types (e.g. search phase processor), throwing them all in one big map would get messier. As a bonus, we'll be able to reuse processor names across different types of processor. Signed-off-by: Michael Froh <froh@amazon.com> (cherry picked from commit eb51f2b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
We needed to check for onOrBefore 2.8 in order to pass back-compat tests on main. Now that we're backporting to 2.8, we need to update the check (on 2.x and on main). Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Gradle Check (Jenkins) Run Completed with:
|
The specific failure is:
It's not the same test as #5957, but I suspect it's related. |
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## 2.x #7669 +/- ##
============================================
- Coverage 70.33% 70.25% -0.08%
+ Complexity 60001 59904 -97
============================================
Files 4885 4885
Lines 288433 288475 +42
Branches 41948 41956 +8
============================================
- Hits 202861 202674 -187
- Misses 68560 68795 +235
+ Partials 17012 17006 -6
|
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after #7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com>
Now that we've backported the SearchPipelineInfo serialization change to 2.x ahead of the 2.8 release, we need to update the compatibility check from <=2.8 to <2.8, as mentioned in the previous TODO. This change should be merged (immediately) after opensearch-project#7669. Signed-off-by: Michael Froh <froh@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Backport eb51f2b from #7597.
Added a commit to update the version check (and remove the TODO talking about updating the version check).