Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.8] Reorder Setting enum to add Extension scope at bottom #7870

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jun 1, 2023

Description

Re-order the Setting enum to add Extension scope setting at the bottom. There was a break in extensions backward compatibility as extensions relies on the order of the enum when sending settings from node <-> extension.

I will open up a separate PR against main to backport to 2.x.

Related Issues

See more details: opensearch-project/opensearch-sdk-java#792

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hard to test this without a BWC but the cause is well understood (transport from a 2.7 import sends an enum ordinal of 4 which is supposed to be NodeScope but wasn't).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

@owaiskazi19 owaiskazi19 merged commit ca167d2 into opensearch-project:2.8 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants