-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Translog metadata upload/download to write/read header and footer via VersionedCodecStreamWrapper #7953
Merged
gbbafna
merged 10 commits into
opensearch-project:main
from
BhumikaSaini-Amazon:refactor-md-ul-dl
Jun 13, 2023
Merged
Refactor Translog metadata upload/download to write/read header and footer via VersionedCodecStreamWrapper #7953
gbbafna
merged 10 commits into
opensearch-project:main
from
BhumikaSaini-Amazon:refactor-md-ul-dl
Jun 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle Check (Jenkins) Run Completed with:
|
BhumikaSaini-Amazon
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
June 8, 2023 06:11
Gradle Check (Jenkins) Run Completed with:
|
linuxpi
reviewed
Jun 8, 2023
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferManager.java
Show resolved
Hide resolved
Changes look good @BhumikaSaini-Amazon. Please check why the tests are failing |
@BhumikaSaini-Amazon Lets update the PR title with an imperative style message. |
Gradle Check (Jenkins) Run Completed with:
|
BhumikaSaini-Amazon
changed the title
Resolve #7228
Refactor Translog metadata upload/download to write/read header and footer via VersionedCodecStreamWrapper
Jun 8, 2023
gbbafna
reviewed
Jun 12, 2023
server/src/main/java/org/opensearch/index/translog/transfer/TranslogTransferMetadata.java
Outdated
Show resolved
Hide resolved
gbbafna
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 1 minor comment
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
BhumikaSaini-Amazon
force-pushed
the
refactor-md-ul-dl
branch
from
June 12, 2023 11:35
245a98a
to
519785e
Compare
Gradle Check (Jenkins) Run Completed with:
|
Failing tests in build:
Flaky test #6287 |
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
gbbafna
approved these changes
Jun 12, 2023
Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 15, 2023
…ooter via VersionedCodecStreamWrapper (opensearch-project#7953) Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…ooter via VersionedCodecStreamWrapper (opensearch-project#7953) (opensearch-project#8036) (cherry picked from commit 4b4d84e) Signed-off-by: Bhumika Saini <sabhumik@amazon.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
…ooter via VersionedCodecStreamWrapper (opensearch-project#7953) Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
…ooter via VersionedCodecStreamWrapper (opensearch-project#7953) Signed-off-by: Bhumika Saini <sabhumik@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor Translog metadata upload/download to write/read header and footer via
VersionedCodecStreamWrapper
introduced in #5917Related Issues
Resolves #7228
Check List
Commit changes are listed out in CHANGELOG.md file (See: Changelog)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.