Default discovery-ec2 region to none. #7969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dblock <dblock@amazon.com>
dblock
requested review from
reta,
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah and
dbwiddis
as code owners
|
@raghuvanshraj do we need to do something similar for repository-s3? |
kotwanikunal
reviewed
Jun 8, 2023
plugins/discovery-ec2/src/main/java/org/opensearch/discovery/ec2/AwsEc2ServiceImpl.java
Show resolved
Hide resolved
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #7969 +/- ##
============================================
+ Coverage 70.84% 70.87% +0.02%
+ Complexity 56464 56437 -27
============================================
Files 4702 4702
Lines 266973 266975 +2
Branches 39157 39158 +1
============================================
+ Hits 189131 189207 +76
+ Misses 61897 61808 -89
- Partials 15945 15960 +15
|
kotwanikunal
approved these changes
Jun 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Signed-off-by: dblock <dblock@amazon.com> (cherry picked from commit f27172b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I think this might be causing the failure in YAML rest tests and third party tests as well. Ref: #7866 |
kotwanikunal
pushed a commit
that referenced
this pull request
Jun 8, 2023
(cherry picked from commit f27172b) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dblock
added a commit
to dblock/OpenSearch
that referenced
this pull request
Jun 8, 2023
Signed-off-by: dblock <dblock@amazon.com>
sandeshkr419
pushed a commit
to sandeshkr419/OpenSearch
that referenced
this pull request
Jun 8, 2023
Signed-off-by: dblock <dblock@amazon.com>
gaiksaya
pushed a commit
to gaiksaya/OpenSearch
that referenced
this pull request
Jun 26, 2023
…search-project#7971) (cherry picked from commit f27172b) Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
imRishN
pushed a commit
to imRishN/OpenSearch
that referenced
this pull request
Jun 27, 2023
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
shiv0408
pushed a commit
to Gaurav614/OpenSearch
that referenced
this pull request
Apr 25, 2024
Signed-off-by: dblock <dblock@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Defaults discovery-ec2 plugin default region to none. According to https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/region-selection.html this should automatically determine the Region from the environment.
Related Issues
Resolves #7959.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.