Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote Store] Add remote segment upload backpressure integ tests #8197

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Jun 21, 2023

Description

This PR adds integration tests for Remote Segment Backpressure.

Related Issues

Resolves #7527

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member Author

Seeing flaky tests - #8059, #5957, #5031 & #8213

@ashking94 ashking94 added Storage:Durability Issues and PRs related to the durability framework skip-changelog v2.9.0 'Issues and PRs related to version v2.9.0' labels Jun 22, 2023
@ashking94 ashking94 self-assigned this Jun 22, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #8197 (34ecc46) into main (0c7ba94) will decrease coverage by 0.18%.
The diff coverage is n/a.

❗ Current head 34ecc46 differs from pull request most recent head 6834632. Consider uploading reports for the commit 6834632 to get more accurate results

@@             Coverage Diff              @@
##               main    #8197      +/-   ##
============================================
- Coverage     70.96%   70.79%   -0.18%     
+ Complexity    56780    56545     -235     
============================================
  Files          4733     4719      -14     
  Lines        268140   267559     -581     
  Branches      39287    39206      -81     
============================================
- Hits         190285   189406     -879     
- Misses        61816    62192     +376     
+ Partials      16039    15961      -78     

see 498 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.backpressure.SearchBackpressureIT.testSearchShardTaskCancellationWithHighCpu

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@ashking94
Copy link
Member Author

Build failed due to lucene version tests failing. Unrelated to this PR. Seeing similar failures in other PR builds as well - https://build.ci.opensearch.org/job/gradle-check/18436/

REPRODUCE WITH: ./gradlew ':qa:verify-version-constants:v2.9.0#integTest' --tests "org.opensearch.qa.verify_version_constants.VerifyVersionConstantsIT.testLuceneVersionConstant" -Dtests.seed=4F5BE3F1B1D72CEF -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=vi-VN -Dtests.timezone=Europe/Warsaw -Druntime.java=20

org.opensearch.qa.verify_version_constants.VerifyVersionConstantsIT > testLuceneVersionConstant FAILED
    java.lang.AssertionError: 
    Expected: <9.7.0>
         but: was <9.6.0>
        at __randomizedtesting.SeedInfo.seed([4F5BE3F1B1D72CEF:C23EDEAD96DFEFA6]:0)
        at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
        at org.junit.Assert.assertThat(Assert.java:964)
        at org.junit.Assert.assertThat(Assert.java:930)
        at org.opensearch.qa.verify_version_constants.VerifyVersionConstantsIT.testLuceneVersionConstant(VerifyVersionConstantsIT.java:56)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@gbbafna gbbafna merged commit 9d9a143 into opensearch-project:main Jun 27, 2023
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Jun 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 27, 2023
)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 9d9a143)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
…ensearch-project#8197)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
sarthakaggarwal97 pushed a commit to sarthakaggarwal97/OpenSearch that referenced this pull request Jun 27, 2023
gbbafna pushed a commit that referenced this pull request Jun 28, 2023
) (#8284)

(cherry picked from commit 9d9a143)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
sudarshan-baliga pushed a commit to Gaurav614/OpenSearch that referenced this pull request Jun 29, 2023
@ashking94
Copy link
Member Author

Backport was merged.

baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ensearch-project#8197)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog Storage:Durability Issues and PRs related to the durability framework v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Remote Store] Add more segment backpressure ITs after remote store stats API is ready
3 participants