Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run precommit and unit tests as part of github actions. #84

Merged
merged 1 commit into from
Feb 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,16 @@ on:

jobs:
search_sanity:
name: "Search Sanity Tests"
name: Search Sanity Checks
runs-on: ubuntu-latest
steps:
- name: "Checkout Search"
- name: Checkout Search
uses: actions/checkout@v2
- name: "Run tests"
run: ./gradlew ':server:test'
- name: Setup Java 14
uses: actions/setup-java@v1
with:
java-version: 14
- name: Run Pre-commit Checks
run: ./gradlew precommit
- name: Run Unit Tests
run: ./gradlew test --parallel
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public enum Mode {

private static final Pattern pattern = Pattern.compile("(\\d+)\\.(\\d+)\\.(\\d+)(-alpha\\d+|-beta\\d+|-rc\\d+)?(-SNAPSHOT)?");

private static final Pattern relaxedPattern = Pattern.compile("(\\d+)\\.(\\d+)\\.(\\d+)(-[a-zA-Z0-9_]+)*?");
private static final Pattern relaxedPattern = Pattern.compile("(\\d+)\\.(\\d+)\\.(\\d+)(-[a-zA-Z0-9_]+|\\+[a-zA-Z0-9_]+)*?");

public Version(int major, int minor, int revision) {
Objects.requireNonNull(major, "major version can't be null");
Expand Down